Allow multiple args values for call and instantiate commands - #480
Merged
Conversation
ascjones
changed the title
cmichi
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the migration from structopt to clap derive #457, the default for
Vecopts is formultiple_occurrences, e.g.--args arg1 --args arg2whereas with structopt it wasmultiple_valuese.g.--args arg1 arg2. This resulted in an error likeFound argument '2' which wasn't expected, or isn't valid in this contextwhen providing multiple values.As noted in docs for
multiple_values, there are issues with its use so we should consider changing how contract arguments are specified.However in the meantime this reverts to the original behaviour with
structoptof accepting multiple values.