Fix cargo contract new template build#204
Merged
Merged
Conversation
cmichi
marked this pull request as draft
March 1, 2021 18:33
Robbepop
reviewed
Mar 2, 2021
Robbepop
left a comment
Robbepop
left a comment
Contributor
There was a problem hiding this comment.
This could also be used to update ink! dependencies from 3.0.0-rc2 to 3.0.0-rc3.
cmichi
changed the title
cargo contract new\ template buildcargo contract new template build
cmichi
marked this pull request as ready for review
March 2, 2021 15:06
ascjones
reviewed
Mar 2, 2021
ascjones
reviewed
Mar 2, 2021
ascjones
left a comment
ascjones
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but we should wait until rc3 is released so we can be 100% sure this combo works
ascjones
approved these changes
Mar 2, 2021
ascjones
left a comment
ascjones
left a comment
Collaborator
There was a problem hiding this comment.
Tested with new rc3 release and it works 👍
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes use-ink/ink#705.
We have a test for
cargo contract new, but the test is currently not run in CI. I've created #180 to fix this. This PR here is a pre-requirement to make the test run in CI again though. So after we have merged this PR I can update the other one.