Generate metadata explicitly for the contract which is build#174
Merged
Conversation
Collaborator
|
Nice! I'll have a proper look on Monday. |
ascjones
reviewed
Feb 15, 2021
cmichi
commented
Feb 16, 2021
ascjones
requested changes
Feb 17, 2021
ascjones
left a comment
ascjones
left a comment
Collaborator
There was a problem hiding this comment.
This introduces a regression, whereby the optimized contract is empty. Building flipper with
-
master
-
this PR
Haven't tried debugging it, but I think it's worth adding an assert for this in ine of the existing build tests to prevent this regression.
This was referenced Feb 18, 2021
ascjones
approved these changes
Feb 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60.