Skip to content

Suppress output on --quiet#165

Merged
cmichi merged 3 commits into
masterfrom
cmichi-make-quiet-really-silent
Feb 3, 2021
Merged

Suppress output on --quiet#165
cmichi merged 3 commits into
masterfrom
cmichi-make-quiet-really-silent

Conversation

@cmichi

@cmichi cmichi commented Jan 29, 2021

Copy link
Copy Markdown
Collaborator

Closes #134.

Supersedes #133.

From the issue:

[…] investigate whether we should print progress updates to stderr as I believe cargo does (needs confirming).

I investigated and the cargo behavior is that progress output is suppressed entirely for --quiet, but errors are still printed to stderr. This is the behavior which I implemented in this PR.

@cmichi
cmichi requested a review from ascjones January 29, 2021 06:37
Comment thread src/cmd/build.rs Outdated
Comment thread src/main.rs Outdated
Comment thread src/util.rs Outdated

@ascjones ascjones left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmichi
cmichi merged commit dfcca38 into master Feb 3, 2021
@cmichi
cmichi deleted the cmichi-make-quiet-really-silent branch February 3, 2021 10:29
@ascjones ascjones mentioned this pull request Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quiet verbosity effects

2 participants