Prevent submitting calls to messages marked as immutable#1397
Merged
Prevent submitting calls to messages marked as immutable#1397
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
SkymanOne
approved these changes
Nov 13, 2023
Co-authored-by: German <german@parity.io>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue: use-ink/ink#1969
ink!can't properly prevent messages supposed to be immutable from changing state regardless. Instead, we rely on the client and tooling to honor themutatesfield in the metadata.Description
Without this change, cargo contract will happily execute messages like the one below. This message receives
&selfwhich signals it should be immutable. Other contract languages, e.g. Solidity, would refuse to compile this. Instead, we rely on the client to prevent it. The rogue balance transfer is just an illustration; Things like that might come from a rogue snippet or sit inside a rogue library.Checklist before requesting a review
CHANGELOG.md