Conversation
This was referenced Oct 3, 2023
This reverts commit a4e8e9e.
smiasojed
reviewed
Oct 3, 2023
Co-authored-by: Sebastian Miasojed <sebastian.miasojed@parity.io>
smiasojed
reviewed
Oct 5, 2023
smiasojed
approved these changes
Oct 5, 2023
Bumps [substrate-build-script-utils](https://github.com/paritytech/polkadot-sdk) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/paritytech/polkadot-sdk/releases) - [Commits](https://github.com/paritytech/polkadot-sdk/commits) --- updated-dependencies: - dependency-name: substrate-build-script-utils dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inkorpallet-contracts?Update to latest subxt release paritytech/subxt#1178
Description
Main changes are to the storage api for fetching all contract infos, and using the legacy rpc client to fetch system properties for token metadata.
best block vs finalized block
The latest release of subxt has changed the default of
at_latestfor reading storage changes to the latest finalized block, where previously it was the best block. Becausecargo-contractextrinsics feature is intended primarily for use during development, and because we usesubstrate-contracts-nodefor testing (which does not have finalization), in this PR I have changed all storage reads to read for the latest best block to maintain the current behaviour.In the future we probably want to add the ability to read from the latest finalized flag, either by default or by way of a flag, see also #672