Skip to content

Commit ed9ada1

Browse files
alexgghmordamax
authored andcommitted
Enable approval-voting-parallel by default on kusama (paritytech#6218)
The approval-voting-parallel introduced with paritytech#4849 has been tested on `versi` and approximately 3 weeks on parity's existing kusama nodes paritytech/devops#3583, things worked as expected, so enable it by default on all kusama nodes in the next release. The next step will be enabling by default on polkadot if no issue arrises while running on kusama. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
1 parent 90b450d commit ed9ada1

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

polkadot/node/service/src/lib.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -759,13 +759,12 @@ pub fn new_full<
759759
Some(backoff)
760760
};
761761

762-
// Running approval voting in parallel is enabled by default on all networks except Polkadot and
763-
// Kusama, unless explicitly enabled by the commandline option.
762+
// Running approval voting in parallel is enabled by default on all networks except Polkadot
763+
// unless explicitly enabled by the commandline option.
764764
// This is meant to be temporary until we have enough confidence in the new system to enable it
765765
// by default on all networks.
766-
let enable_approval_voting_parallel = (!config.chain_spec.is_kusama() &&
767-
!config.chain_spec.is_polkadot()) ||
768-
enable_approval_voting_parallel;
766+
let enable_approval_voting_parallel =
767+
!config.chain_spec.is_polkadot() || enable_approval_voting_parallel;
769768

770769
let disable_grandpa = config.disable_grandpa;
771770
let name = config.network.node_name.clone();

prdoc/pr_6218.prdoc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
title: Enable approval-voting-parallel by default on kusama
2+
3+
doc:
4+
- audience: Node Dev
5+
description: |
6+
Enable approval-voting-parallel by default on kusama
7+
crates:
8+
- name: polkadot-service
9+
bump: patch

0 commit comments

Comments
 (0)