feat: Update release workflow per pardeike's feedback

- Tests now mandatory before release (no bypassing failures)
- Build all three library variants (Lib.Harmony, Lib.Harmony.Thin, Lib.Harmony.Ref)
- Create and upload zip files for each library variant to GitHub Release
- Use git submodule state for MonoMod.Core instead of NuGet
- Add proper permissions for workflow
- Create draft releases instead of publishing directly
- Add all required .NET SDK versions
- Improve build and test output messages

Author: Nonanti

.github/workflows/release.yml

@@ -26,17 +26,28 @@ env:
 jobs:
   build-and-release:
     runs-on: ubuntu-latest
+    permissions:
+      contents: write
+      packages: write
 
     steps:
     - name: Checkout repository
       uses: actions/checkout@v4
       with:
-        # Don't use submodules: recursive here - it will fail!
+        submodules: recursive
         fetch-depth: 0
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
-      # Let it auto-detect and install required versions
+      with:
+        dotnet-version: |
+          3.0.x
+          3.1.x
+          5.0.x
+          6.0.x
+          7.0.x
+          8.0.x
+          9.0.x
     
     - name: Determine version
       id: version
@@ -62,50 +73,92 @@ jobs:
         BASE_VERSION=$(echo $VERSION | sed 's/-.*//')
         PRERELEASE_SUFFIX=$(echo $VERSION | grep -oP '\-.*' || echo "")
         
-        # Update Directory.Build.props - use MonoMod from NuGet
+        # Update Directory.Build.props
         sed -i "s|<HarmonyVersion>.*</HarmonyVersion>|<HarmonyVersion>${BASE_VERSION}.0</HarmonyVersion>|" Directory.Build.props
         sed -i "s|<HarmonyPrerelease>.*</HarmonyPrerelease>|<HarmonyPrerelease>${PRERELEASE_SUFFIX}</HarmonyPrerelease>|" Directory.Build.props
         
-        # IMPORTANT: Set MonoModCoreVersion to avoid submodule dependency
-        sed -i "s|<MonoModCoreVersion>.*</MonoModCoreVersion>|<MonoModCoreVersion>1.3.0</MonoModCoreVersion>|" Directory.Build.props
+        # Use current git submodule state for MonoMod.Core - set empty to use submodule
+        sed -i "s|<MonoModCoreVersion>.*</MonoModCoreVersion>|<MonoModCoreVersion></MonoModCoreVersion>|" Directory.Build.props
         
         echo "Updated Directory.Build.props:"
         grep -E "HarmonyVersion|HarmonyPrerelease|MonoModCoreVersion" Directory.Build.props
     
+    - name: Restore dependencies
+      run: dotnet restore Harmony.sln
+    
     - name: Build Solution
       run: |
-        # Use the same build command as test-build.yml
-        dotnet build -c Release Harmony.sln
+        # Build all three library variants as required by pardeike
+        echo "Building Lib.Harmony (full package with dependencies merged)..."
+        dotnet build -c Release Lib.Harmony/Lib.Harmony.csproj
+        
+        echo "Building Lib.Harmony.Thin (lightweight without merged dependencies)..."
+        dotnet build -c Release Lib.Harmony.Thin/Lib.Harmony.Thin.csproj
+        
+        echo "Building Lib.Harmony.Ref (reference assemblies only)..."
+        dotnet build -c Release Lib.Harmony.Ref/Lib.Harmony.Ref.csproj
     
     - name: Run Tests
       run: |
-        dotnet test -c Release --no-build --verbosity normal || echo "Tests completed with warnings"
+        # Tests MUST pass before release - no bypassing failures
+        echo "Running all test projects..."
+        dotnet test -c Release --no-build --verbosity normal HarmonyTests/HarmonyTests.csproj
+        TEST_RESULT=$?
+        if [ $TEST_RESULT -ne 0 ]; then
+          echo "❌ Tests failed with exit code $TEST_RESULT. Release cannot proceed."
+          echo "Please fix all test failures before creating a release."
+          exit 1
+        fi
+        echo "✅ All tests passed successfully!"
     
     - name: Create NuGet Packages
       run: |
-        # Build the actual NuGet packages
+        # Build NuGet packages for all three library variants
         dotnet pack Lib.Harmony/Lib.Harmony.csproj -c Release --no-build --output ./artifacts
         dotnet pack Lib.Harmony.Thin/Lib.Harmony.Thin.csproj -c Release --no-build --output ./artifacts  
         dotnet pack Lib.Harmony.Ref/Lib.Harmony.Ref.csproj -c Release --no-build --output ./artifacts
         
         echo "Generated packages:"
         ls -la ./artifacts/
     
+    - name: Create Release Zip Files
+      run: |
+        # Create zip files for each library variant
+        mkdir -p ./release-zips
+        
+        # Zip Lib.Harmony
+        cd Lib.Harmony/bin/Release
+        zip -r ../../../release-zips/Lib.Harmony-v${{ steps.version.outputs.version }}.zip .
+        cd ../../..
+        
+        # Zip Lib.Harmony.Thin
+        cd Lib.Harmony.Thin/bin/Release
+        zip -r ../../../release-zips/Lib.Harmony.Thin-v${{ steps.version.outputs.version }}.zip .
+        cd ../../..
+        
+        # Zip Lib.Harmony.Ref
+        cd Lib.Harmony.Ref/bin/Release
+        zip -r ../../../release-zips/Lib.Harmony.Ref-v${{ steps.version.outputs.version }}.zip .
+        cd ../../..
+        
+        echo "Generated zip files:"
+        ls -la ./release-zips/
+    
     - name: Upload Artifacts
       uses: actions/upload-artifact@v4
       with:
         name: nuget-packages
         path: ./artifacts/*.nupkg
         if-no-files-found: warn
 
-    - name: Upload Harmony Zip
+    - name: Upload Release Zips
       uses: actions/upload-artifact@v4
       with:
-        name: Harmony-Release
-        path: Harmony/bin/*.zip
-        if-no-files-found: warn
+        name: Harmony-Release-Zips
+        path: ./release-zips/*.zip
+        if-no-files-found: error
 
-    # Publishing steps (only on tag push or manual trigger from master)
+    # Publishing steps (only on tag push or manual trigger from master after tests pass)
     - name: Publish to NuGet
       if: success() && (github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.ref == 'refs/heads/master'))
       run: |
@@ -169,7 +222,7 @@ jobs:
           - [Changelog](https://github.com/${{ github.repository }}/commits/v${{ steps.version.outputs.version }})
         files: |
           ./artifacts/*.nupkg
-          Harmony/bin/*.zip
+          ./release-zips/*.zip
         prerelease: ${{ steps.version.outputs.is_prerelease == 'true' }}
-        draft: false
+        draft: true
         token: ${{ secrets.GITHUB_TOKEN }}