Properly assigning styles by deep copy

* property assigning styles by deep copy
+ var to const/let refactoring

* reduce async

Author: Siemienik

lib/doc/row.js

@@ -1,12 +1,12 @@
 'use strict';
 
-var _ = require('../utils/under-dash');
+const _ = require('../utils/under-dash');
 
-var Enums = require('./enums');
-var colCache = require('./../utils/col-cache');
-var Cell = require('./cell');
+const Enums = require('./enums');
+const colCache = require('./../utils/col-cache');
+const Cell = require('./cell');
 
-var Row = module.exports = function(worksheet, number) {
+const Row = module.exports = function (worksheet, number) {
   this._worksheet = worksheet;
   this._number = number;
   this._cells = [];
@@ -43,9 +43,9 @@ Row.prototype = {
 
   // given {address, row, col}, find or create new cell
   getCellEx: function(address) {
-    var cell = this._cells[address.col - 1];
+    let cell = this._cells[address.col - 1];
     if (!cell) {
-      var column = this._worksheet.getColumn(address.col);
+      const column = this._worksheet.getColumn(address.col);
       cell = new Cell(this, column, address.address);
       this._cells[address.col - 1] = cell;
     }
@@ -56,7 +56,7 @@ Row.prototype = {
   getCell: function(col) {
     if (typeof col === 'string') {
       // is it a key?
-      var column = this._worksheet.getColumnKey(col);
+      const column = this._worksheet.getColumnKey(col);
       if (column) {
         col = column.number;
       } else {
@@ -73,11 +73,11 @@ Row.prototype = {
 
   // remove cell(s) and shift all higher cells down by count
   splice: function(start, count) {
-    var inserts = Array.prototype.slice.call(arguments, 2);
-    var nKeep = start + count;
-    var nExpand = inserts.length - count;
-    var nEnd = this._cells.length;
-    var i, cSrc, cDst;
+    const inserts = Array.prototype.slice.call(arguments, 2);
+    const nKeep = start + count;
+    const nExpand = inserts.length - count;
+    const nEnd = this._cells.length;
+    let i, cSrc, cDst;
 
     if (nExpand < 0) {
       // remove cells
@@ -115,8 +115,8 @@ Row.prototype = {
       options = null;
     }
     if (options && options.includeEmpty) {
-      var n = this._cells.length;
-      for (var i = 1; i <= n; i++) {
+      const n = this._cells.length;
+      for (let i = 1; i <= n; i++) {
         iteratee(this.getCell(i), i);
       }
     } else {
@@ -146,7 +146,7 @@ Row.prototype = {
 
   // return a sparse array of cell values
   get values() {
-    var values = [];
+    const values = [];
     this._cells.forEach(function(cell) {
       if (cell && (cell.type !== Enums.ValueType.Null)) {
         values[cell.col] = cell.value;
@@ -162,7 +162,7 @@ Row.prototype = {
     if (!value) {
       // empty row
     } else if (value instanceof Array) {
-      var offset = 0;
+      let offset = 0;
       if (value.hasOwnProperty('0')) {
         // contiguous array - start at column 1
         offset = 1;
@@ -201,7 +201,7 @@ Row.prototype = {
     return this._cells.length;
   },
   get actualCellCount() {
-    var count = 0;
+    let count = 0;
     this.eachCell(function() {
       count++;
     });
@@ -210,8 +210,8 @@ Row.prototype = {
 
   // get the min and max column number for the non-null cells in this row or null
   get dimensions() {
-    var min = 0;
-    var max = 0;
+    let min = 0;
+    let max = 0;
     this._cells.forEach(function(cell) {
       if (cell && (cell.type !== Enums.ValueType.Null)) {
         if (!min || (min > cell.col)) {
@@ -288,12 +288,12 @@ Row.prototype = {
 
   // =========================================================================
   get model() {
-    var cells = [];
-    var min = 0;
-    var max = 0;
+    const cells = [];
+    let min = 0;
+    let max = 0;
     this._cells.forEach(function(cell) {
       if (cell) {
-        var cellModel = cell.model;
+        const cellModel = cell.model;
         if (cellModel) {
           if (!min || (min > cell.col)) {
             min = cell.col;
@@ -323,21 +323,21 @@ Row.prototype = {
       throw new Error('Invalid row number in model');
     }
     this._cells = [];
-    var previousAddress;
+    let previousAddress;
     value.cells.forEach(cellModel => {
       switch (cellModel.type) {
         case Cell.Types.Merge:
           // special case - don't add this types
           break;
         default:
-          var address;
+          let address;
           if (cellModel.address) {
             address = colCache.decodeAddress(cellModel.address);
           } else if (previousAddress) {
             // This is a <c> element without an r attribute
             // Assume that it's the cell for the next column
-            var row = previousAddress.row;
-            var col = previousAddress.col + 1;
+            const row = previousAddress.row;
+            const col = previousAddress.col + 1;
             address = {
               row: row,
               col: col,
@@ -346,7 +346,7 @@ Row.prototype = {
             };
           }
           previousAddress = address;
-          var cell = this.getCellEx(address);
+          const cell = this.getCellEx(address);
           cell.model = cellModel;
           break;
       }
@@ -361,6 +361,6 @@ Row.prototype = {
     this.hidden = value.hidden;
     this.outlineLevel = value.outlineLevel || 0;
 
-    this.style = value.style || {};
+    this.style = value.style && JSON.parse(JSON.stringify(value.style)) || {};
   }
 };

spec/integration/data/test-row-styles.xlsx

@@ -1,21 +1,21 @@
 'use strict';
 
-var verquire = require('../utils/verquire');
-var testutils = require('../utils/index');
-var fs = require('fs');
-var expect = require('chai').expect;
+const verquire = require('../utils/verquire');
+const testutils = require('../utils/index');
+const fs = require('fs');
+const expect = require('chai').expect;
 
-var Excel = verquire('excel');
+const Excel = verquire('excel');
 
-var TEST_FILE_NAME = './spec/out/wb.test.xlsx';
+const TEST_FILE_NAME = './spec/out/wb.test.xlsx';
 
 // need some architectural changes to make stream read work properly
 // because of: shared strings, sheet names, etc are not read in guaranteed order
 describe('WorkbookReader', function() {
   describe('Serialise', function() {
     it('xlsx file', function() {
       this.timeout(10000);
-      var wb = testutils.createTestBook(new Excel.Workbook(), 'xlsx');
+      const wb = testutils.createTestBook(new Excel.Workbook(), 'xlsx');
 
       return wb.xlsx.writeFile(TEST_FILE_NAME)
         .then(function() {
@@ -27,7 +27,7 @@ describe('WorkbookReader', function() {
   describe('#readFile', function() {
     describe('Row limit', function() {
       it('should bail out if the file contains more rows than the limit', function() {
-        var workbook = new Excel.Workbook();
+        const workbook = new Excel.Workbook();
         // The Fibonacci sheet has 19 rows
         return workbook.xlsx.readFile('./spec/integration/data/fibonacci.xlsx', {maxRows: 10})
           .then(function() {
@@ -39,7 +39,7 @@ describe('WorkbookReader', function() {
 
       it('should fail fast on a huge file', function() {
         this.timeout(20000);
-        var workbook = new Excel.Workbook();
+        const workbook = new Excel.Workbook();
         return workbook.xlsx.readFile('./spec/integration/data/huge.xlsx', {maxRows: 100})
           .then(function() {
             throw new Error('Promise unexpectedly fulfilled');
@@ -49,7 +49,7 @@ describe('WorkbookReader', function() {
       });
 
       it('should parse fine if the limit is not exceeded', function() {
-        var workbook = new Excel.Workbook();
+        const workbook = new Excel.Workbook();
         return workbook.xlsx.readFile('./spec/integration/data/fibonacci.xlsx', {maxRows: 20});
       });
     });
@@ -58,7 +58,7 @@ describe('WorkbookReader', function() {
   describe('#read', function() {
     describe('Row limit', function() {
       it('should bail out if the file contains more rows than the limit', function() {
-        var workbook = new Excel.Workbook();
+        const workbook = new Excel.Workbook();
         // The Fibonacci sheet has 19 rows
         return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/fibonacci.xlsx'), {maxRows: 10})
           .then(function() {
@@ -69,16 +69,39 @@ describe('WorkbookReader', function() {
       });
 
       it('should parse fine if the limit is not exceeded', function() {
-        var workbook = new Excel.Workbook();
+        const workbook = new Excel.Workbook();
         return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/fibonacci.xlsx'), {maxRows: 20});
       });
     });
   });
+  
+  describe('edit styles in existing file', function(){
+    beforeEach(function(){
+      this.wb = new Excel.Workbook();
+      return this.wb.xlsx.readFile('./spec/integration/data/test-row-styles.xlsx');
+    });
+    
+    it('edit styles of single row instead of all', function () {
+      const ws = this.wb.getWorksheet(1);
+
+      ws.eachRow((row, rowNo) => {
+        rowNo % 5 === 0 && (row.font = {color: {argb: '00ff00'}})
+      });
+      
+      expect(ws.getRow(3).font.color.argb).to.be.equal(ws.getRow(6).font.color.argb);
+      expect(ws.getRow(6).font.color.argb).to.be.equal(ws.getRow(9).font.color.argb);
+      expect(ws.getRow(9).font.color.argb).to.be.equal(ws.getRow(12).font.color.argb);
+      expect(ws.getRow(12).font.color.argb).not.to.be.equal(ws.getRow(15).font.color.argb);
+      expect(ws.getRow(15).font.color.argb).not.to.be.equal(ws.getRow(18).font.color.argb);
+      expect(ws.getRow(15).font.color.argb).to.be.equal(ws.getRow(10).font.color.argb);
+      expect(ws.getRow(10).font.color.argb).to.be.equal(ws.getRow(5).font.color.argb);
+    })
+  });
 
   describe('with a spreadsheet that contains formulas', function() {
     before(function() {
-      var testContext = this;
-      var workbook = new Excel.Workbook();
+      const testContext = this;
+      const workbook = new Excel.Workbook();
       return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/formulas.xlsx'))
         .then(function() {
           testContext.worksheet = workbook.getWorksheet();
@@ -129,8 +152,8 @@ describe('WorkbookReader', function() {
 
   describe('with a spreadsheet that contains a shared string with an escaped underscore', function() {
     before(function() {
-      var testContext = this;
-      var workbook = new Excel.Workbook();
+      const testContext = this;
+      const workbook = new Excel.Workbook();
       return workbook.xlsx.read(fs.createReadStream('./spec/integration/data/shared_string_with_escape.xlsx'))
         .then(function() {
           testContext.worksheet = workbook.getWorksheet();