chore: stop testing Rails secrets

Author: palkan

.github/workflows/rspec.yml

@@ -33,7 +33,7 @@ jobs:
         - ruby: "3.2"
           gemfile: "gemfiles/rails7.gemfile"
           rbs: 'false'
-        - ruby: "3.2"
+        - ruby: "3.3"
           gemfile: "gemfiles/railsmaster.gemfile"
           rbs: 'false'
         - ruby: "3.1"
@@ -69,9 +69,6 @@ jobs:
     - name: Run RSpec without rails
       run: |
         bundle exec rake spec:norails
-    - name: Run Rails secrets tests for uninitialized app
-      run: |
-        bundle exec rake spec:secrets
     - name: Run Rails autoload tests
       run: |
         bundle exec rake spec:autoload

README.md

@@ -73,7 +73,7 @@ end
 
 Using Ruby classes to represent configuration allows you to add helper methods and computed parameters easily, makes the configuration **testable**.
 
-The `anyway_config` gem takes care of loading parameters from **different sources** (YAML, credentials/secrets, environment variables, etc.). Internally, we use a _pipeline pattern_ and provide the [Loaders API](#data-loaders) to manage and [extend](#custom-loaders) its functionality.
+The `anyway_config` gem takes care of loading parameters from **different sources** (YAML, credentials, environment variables, etc.). Internally, we use a _pipeline pattern_ and provide the [Loaders API](#data-loaders) to manage and [extend](#custom-loaders) its functionality.
 
 Check out the libraries using Anyway Config for more examples:
 
@@ -270,7 +270,6 @@ This feature is similar to `Rails.application.config_for` but more powerful:
 | Feature | Rails | Anyway Config |
 | ------------- |-------------:| -----:|
 | Load data from `config/app.yml` | ✅ | ✅ |
-| Load data from `secrets` | ❌ | ✅ |
 | Load data from `credentials` | ❌ | ✅ |
 | Load data from environment | ❌ | ✅ |
 | Load data from [other sources](#data-loaders) | ❌ | ✅ |

Rakefile

@@ -20,15 +20,6 @@ RSpec::Core::RakeTask.new("spec:norails") do |task|
   task.verbose = false
 end
 
-desc "Run Rails secrets tests for uninitialized app"
-RSpec::Core::RakeTask.new("spec:secrets") do |task|
-  ENV["DO_NOT_INITIALIZE_RAILS"] = "1"
-  ENV["USE_APP_CONFIGS"] = "0"
-  ENV["NORAILS"] = "0"
-  task.rspec_opts = "--order defined --tag secrets"
-  task.verbose = false
-end
-
 desc "Run Rails autoload tests for app/configs"
 RSpec::Core::RakeTask.new("spec:autoload") do |task|
   ENV["USE_APP_CONFIGS"] = "1"
@@ -107,4 +98,4 @@ namespace :spec do
 end
 
 desc "Run the all specs"
-task default: %w[rubocop rubocop:md steep spec:norails spec spec:secrets spec:autoload spec:rbs]
+task default: %w[rubocop rubocop:md steep spec:norails spec spec:autoload spec:rbs]

spec/config_spec.rb

@@ -455,7 +455,7 @@ def submeta=(val)
       end
     end
 
-    describe "#to_source_trace" do
+    describe "#to_source_trace", env_kot: false do
       let(:conf) { CoolConfig.new }
 
       around do |ex|
@@ -606,7 +606,7 @@ def submeta=(val)
       end
     end
 
-    describe "#pretty_print" do
+    describe "#pretty_print", env_kot: false do
       let(:overrides) { {} }
       let(:conf) { CoolConfig.new(overrides) }
 

spec/dummy/config/application.rb

@@ -10,6 +10,7 @@
 
 module Dummy
   class Application < Rails::Application
+    config.load_defaults Rails::VERSION::STRING.split(".").take(2).join(".").to_f
     config.logger = Logger.new("/dev/null")
     config.eager_load = ENV["DO_NOT_INITIALIZE_RAILS"] != "1"
 

spec/dummy/config/secrets.yml

@@ -15,9 +15,6 @@
     data = Anyway::Config.for(:my_app)
     expect(data[:test]).to eq 1
     expect(data[:name]).to eq "my_app"
-    unless NOSECRETS
-      expect(data[:secret]).to eq "my_secret"
-    end
     expect(data[:credo]).to eq "my_credo" if Rails.application.respond_to?(:credentials)
   end
 
@@ -49,7 +46,6 @@
       data = Anyway::Config.for(:my_app)
       expect(data[:test]).to eq 1
       expect(data[:name]).to eq "my_app"
-      expect(data[:secret]).to eq "my_secret" unless NOSECRETS
       expect(data[:credo]).to eq "my_credo" if Rails.application.respond_to?(:credentials)
       expect(data[:credo_local]).to eq "betheone" if Rails.application.respond_to?(:credentials)
     end

spec/dynamic_config_spec.rb

@@ -21,13 +21,12 @@
 
     if !NORAILS
       if Rails.application.respond_to?(:credentials)
-        it "load config from secrets and credentials" do
+        it "load config from credentials" do
           expect(conf.user[:name]).to eq "secret man"
-          expect(conf.meta).to eq("kot" => "leta")
           expect(conf.user[:password]).to eq "root"
         end
 
-        it "sets overrides after loading secrets" do
+        it "sets overrides after loading" do
           config = CoolConfig.new(user: {"password" => "override"})
           expect(config.user[:name]).to eq "secret man"
           expect(config.user[:password]).to eq "override"
@@ -43,7 +42,7 @@
           end
         end
 
-        context "when using local files" do
+        context "when using local files", env_kot: false do
           around do |ex|
             Anyway::Settings.use_local_files = true
             ex.run
@@ -52,9 +51,7 @@
 
           it "load config local credentials too" do
             expect(conf.user[:name]).to eq "secret man"
-            unless NOSECRETS
-              expect(conf.meta).to eq("kot" => "murkot")
-            end
+            expect(conf.meta).to eq("kot" => "murkot")
             expect(conf.user[:password]).to eq "password"
           end
         end
@@ -81,7 +78,7 @@
                 },
                 "port" => {value: 8080, source: {type: :defaults}},
                 "meta" => {
-                  "kot" => {value: "leta", source: NOSECRETS ? {type: :env, key: "COOL_META__KOT"} : {type: :secrets}}
+                  "kot" => {value: "leta", source: {type: :env, key: "COOL_META__KOT"}}
                 }
               }
             )

spec/rails/config_spec.rb

@@ -51,10 +51,9 @@
   config.filter_run :focus
   config.run_all_when_everything_filtered = true
 
-  if NOSECRETS
-    config.around(:each, type: :config) do |ex|
-      with_env("COOL_META__KOT" => "leta", &ex)
-    end
+  config.around(:each, type: :config) do |ex|
+    next ex.run if ex.metadata[:env_kot] == false
+    with_env("COOL_META__KOT" => "leta", &ex)
   end
 
   config.order = :random