Add self to python keywords
#984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
The code generator creates an
__init__()method for the conjure bean type, which includesselfalong every class field. If a field is calledself, python throws aSyntaxError: duplicate argument 'self' in function definitionAdding
selfto the python keywords so the generator adds an underscore suffix in that caseAfter this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?
This is technically a breaking change (as the class needs to be called with
MyClass(self_=value)instead ofMyClass(self=value)- but in practice, this would never have happened as the previous code would have thrown a SyntaxError.