Skip to content

Conversation

@AlexandreGuinaudeau
Copy link
Contributor

Before this PR

The code generator creates an __init__() method for the conjure bean type, which includes self along every class field. If a field is called self, python throws a SyntaxError: duplicate argument 'self' in function definition

Adding self to the python keywords so the generator adds an underscore suffix in that case

After this PR

==COMMIT_MSG==
==COMMIT_MSG==

Possible downsides?

This is technically a breaking change (as the class needs to be called with MyClass(self_=value) instead of MyClass(self=value) - but in practice, this would never have happened as the previous code would have thrown a SyntaxError.

@changelog-app
Copy link

changelog-app bot commented Mar 10, 2025

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add self to python keywords

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit ce9be3b into develop Mar 10, 2025
7 checks passed
@bulldozer-bot bulldozer-bot bot deleted the AlexandreGuinaudeau-patch-1 branch March 10, 2025 20:24
@autorelease3
Copy link

autorelease3 bot commented Mar 10, 2025

Released 4.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants