Skip to content

Commit 1bdbe5b

Browse files
author
pakoito
committed
Fix RxJava 2.X change from Function to ObservableTransformer
1 parent 5c3ea32 commit 1bdbe5b

3 files changed

Lines changed: 71 additions & 68 deletions

File tree

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ Observable<String> getUserFriends =
4545

4646
### Compose comprehensions
4747

48-
RxComprehensions contains static methods `doCo()` for `compose()`. Each takes from 1 to 9 `Transformer<T, U>` (RxJava 1.X) or `Function<Observable<T>, Observable<U>` (RxJava 2.X), and returns an `Observable` of the type of the return of the last one.
48+
RxComprehensions contains static methods `doCo()` for `compose()`. Each takes from 1 to 9 `Transformer<T, U>` (RxJava 1.X) or `ObservableTransformer<T, U>` (RxJava 2.X), and returns an `Observable` of the type of the return of the last one.
4949

5050
```java
5151
Observable<List<Siblings>> getRelatives =
@@ -61,15 +61,15 @@ Observable<List<Siblings>> getRelatives =
6161

6262
Observable<RelativeDto> requestRelative(String id) { /* ... */ }
6363

64-
Transformer<RelativeDto, RelativeDto> validate() { /* ... */ }
64+
ObservableTransformer<RelativeDto, RelativeDto> validate() { /* ... */ }
6565

66-
Transformer<RelativeDto, RelativeDto> assureThreads(Scheduler in, Scheduler out) { /* ... */ }
66+
ObservableTransformer<RelativeDto, RelativeDto> assureThreads(Scheduler in, Scheduler out) { /* ... */ }
6767

68-
Transformer<RelativeDto, RelativeDto> respectLifecycle(Activity activity) { /* ... */ }
68+
ObservableTransformer<RelativeDto, RelativeDto> respectLifecycle(Activity activity) { /* ... */ }
6969

70-
Transformer<RelativeDto, Relative> toUILayerModel() { /* ... */ }
70+
ObservableTransformer<RelativeDto, Relative> toUILayerModel() { /* ... */ }
7171

72-
Transformer<Relative, List<Siblings>> groupSiblings() { /* ... */ }
72+
ObservableTransformer<Relative, List<Siblings>> groupSiblings() { /* ... */ }
7373
```
7474

7575
## Distribution

rxcomprehensions2/src/main/java/com/pacoworks/rxcomprehensions/RxComprehensions.java

Lines changed: 55 additions & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.concurrent.Callable;
2020

2121
import io.reactivex.Observable;
22+
import io.reactivex.ObservableTransformer;
2223
import io.reactivex.functions.BiFunction;
2324
import io.reactivex.functions.Function;
2425
import io.reactivex.functions.Function3;
@@ -1256,58 +1257,58 @@ public Observable<R> apply(final I i) throws Exception {
12561257

12571258

12581259
/**
1259-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1260+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
12601261
*
12611262
* @return composed Observable
12621263
*/
12631264
public static <A, R> Observable<R> doCo(
12641265
final Callable<Observable<A>> zero,
1265-
final Function<Observable<A>, Observable<R>> one) throws Exception {
1266+
final ObservableTransformer<A, R> one) throws Exception {
12661267
return zero.call()
12671268
.compose(one);
12681269
}
12691270

12701271
/**
1271-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1272+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
12721273
*
12731274
* @return composed Observable
12741275
*/
12751276
public static <A, B, R> Observable<R> doCo(
12761277
final Callable<Observable<A>> zero,
1277-
final Function<Observable<A>, Observable<B>> one,
1278-
final Function<Observable<B>, Observable<R>> two) throws Exception {
1278+
final ObservableTransformer<A, B> one,
1279+
final ObservableTransformer<B, R> two) throws Exception {
12791280
return zero.call()
12801281
.compose(one)
12811282
.compose(two);
12821283
}
12831284

12841285
/**
1285-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1286+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
12861287
*
12871288
* @return composed Observable
12881289
*/
12891290
public static <A, B, C, R> Observable<R> doCo(
12901291
final Callable<Observable<A>> zero,
1291-
final Function<Observable<A>, Observable<B>> one,
1292-
final Function<Observable<B>, Observable<C>> two,
1293-
final Function<Observable<C>, Observable<R>> three) throws Exception {
1292+
final ObservableTransformer<A, B> one,
1293+
final ObservableTransformer<B, C> two,
1294+
final ObservableTransformer<C, R> three) throws Exception {
12941295
return zero.call()
12951296
.compose(one)
12961297
.compose(two)
12971298
.compose(three);
12981299
}
12991300

13001301
/**
1301-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1302+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
13021303
*
13031304
* @return composed Observable
13041305
*/
13051306
public static <A, B, C, D, R> Observable<R> doCo(
13061307
final Callable<Observable<A>> zero,
1307-
final Function<Observable<A>, Observable<B>> one,
1308-
final Function<Observable<B>, Observable<C>> two,
1309-
final Function<Observable<C>, Observable<D>> three,
1310-
final Function<Observable<D>, Observable<R>> four) throws Exception {
1308+
final ObservableTransformer<A, B> one,
1309+
final ObservableTransformer<B, C> two,
1310+
final ObservableTransformer<C, D> three,
1311+
final ObservableTransformer<D, R> four) throws Exception {
13111312
return zero.call()
13121313
.compose(one)
13131314
.compose(two)
@@ -1316,17 +1317,17 @@ public static <A, B, C, D, R> Observable<R> doCo(
13161317
}
13171318

13181319
/**
1319-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1320+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
13201321
*
13211322
* @return composed Observable
13221323
*/
13231324
public static <A, B, C, D, E, R> Observable<R> doCo(
13241325
final Callable<Observable<A>> zero,
1325-
final Function<Observable<A>, Observable<B>> one,
1326-
final Function<Observable<B>, Observable<C>> two,
1327-
final Function<Observable<C>, Observable<D>> three,
1328-
final Function<Observable<D>, Observable<E>> four,
1329-
final Function<Observable<E>, Observable<R>> five) throws Exception {
1326+
final ObservableTransformer<A, B> one,
1327+
final ObservableTransformer<B, C> two,
1328+
final ObservableTransformer<C, D> three,
1329+
final ObservableTransformer<D, E> four,
1330+
final ObservableTransformer<E, R> five) throws Exception {
13301331
return zero.call()
13311332
.compose(one)
13321333
.compose(two)
@@ -1336,18 +1337,18 @@ public static <A, B, C, D, E, R> Observable<R> doCo(
13361337
}
13371338

13381339
/**
1339-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1340+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
13401341
*
13411342
* @return composed Observable
13421343
*/
13431344
public static <A, B, C, D, E, F, R> Observable<R> doCo(
13441345
final Callable<Observable<A>> zero,
1345-
final Function<Observable<A>, Observable<B>> one,
1346-
final Function<Observable<B>, Observable<C>> two,
1347-
final Function<Observable<C>, Observable<D>> three,
1348-
final Function<Observable<D>, Observable<E>> four,
1349-
final Function<Observable<E>, Observable<F>> five,
1350-
final Function<Observable<F>, Observable<R>> six) throws Exception {
1346+
final ObservableTransformer<A, B> one,
1347+
final ObservableTransformer<B, C> two,
1348+
final ObservableTransformer<C, D> three,
1349+
final ObservableTransformer<D, E> four,
1350+
final ObservableTransformer<E, F> five,
1351+
final ObservableTransformer<F, R> six) throws Exception {
13511352
return zero.call()
13521353
.compose(one)
13531354
.compose(two)
@@ -1358,19 +1359,19 @@ public static <A, B, C, D, E, F, R> Observable<R> doCo(
13581359
}
13591360

13601361
/**
1361-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1362+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
13621363
*
13631364
* @return composed Observable
13641365
*/
13651366
public static <A, B, C, D, E, F, G, R> Observable<R> doCo(
13661367
final Callable<Observable<A>> zero,
1367-
final Function<Observable<A>, Observable<B>> one,
1368-
final Function<Observable<B>, Observable<C>> two,
1369-
final Function<Observable<C>, Observable<D>> three,
1370-
final Function<Observable<D>, Observable<E>> four,
1371-
final Function<Observable<E>, Observable<F>> five,
1372-
final Function<Observable<F>, Observable<G>> six,
1373-
final Function<Observable<G>, Observable<R>> seven) throws Exception {
1368+
final ObservableTransformer<A, B> one,
1369+
final ObservableTransformer<B, C> two,
1370+
final ObservableTransformer<C, D> three,
1371+
final ObservableTransformer<D, E> four,
1372+
final ObservableTransformer<E, F> five,
1373+
final ObservableTransformer<F, G> six,
1374+
final ObservableTransformer<G, R> seven) throws Exception {
13741375
return zero.call()
13751376
.compose(one)
13761377
.compose(two)
@@ -1382,20 +1383,20 @@ public static <A, B, C, D, E, F, G, R> Observable<R> doCo(
13821383
}
13831384

13841385
/**
1385-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1386+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
13861387
*
13871388
* @return composed Observable
13881389
*/
13891390
public static <A, B, C, D, E, F, G, H, R> Observable<R> doCo(
13901391
final Callable<Observable<A>> zero,
1391-
final Function<Observable<A>, Observable<B>> one,
1392-
final Function<Observable<B>, Observable<C>> two,
1393-
final Function<Observable<C>, Observable<D>> three,
1394-
final Function<Observable<D>, Observable<E>> four,
1395-
final Function<Observable<E>, Observable<F>> five,
1396-
final Function<Observable<F>, Observable<G>> six,
1397-
final Function<Observable<G>, Observable<H>> seven,
1398-
final Function<Observable<H>, Observable<R>> eight) throws Exception {
1392+
final ObservableTransformer<A, B> one,
1393+
final ObservableTransformer<B, C> two,
1394+
final ObservableTransformer<C, D> three,
1395+
final ObservableTransformer<D, E> four,
1396+
final ObservableTransformer<E, F> five,
1397+
final ObservableTransformer<F, G> six,
1398+
final ObservableTransformer<G, H> seven,
1399+
final ObservableTransformer<H, R> eight) throws Exception {
13991400
return zero.call()
14001401
.compose(one)
14011402
.compose(two)
@@ -1408,21 +1409,21 @@ public static <A, B, C, D, E, F, G, H, R> Observable<R> doCo(
14081409
}
14091410

14101411
/**
1411-
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(Function)}.
1412+
* Composes an {@link Observable} from multiple {@link Function} chained by {@link Observable#compose(ObservableTransformer)}.
14121413
*
14131414
* @return composed Observable
14141415
*/
14151416
public static <A, B, C, D, E, F, G, H, I, R> Observable<R> doCo(
14161417
final Callable<Observable<A>> zero,
1417-
final Function<Observable<A>, Observable<B>> one,
1418-
final Function<Observable<B>, Observable<C>> two,
1419-
final Function<Observable<C>, Observable<D>> three,
1420-
final Function<Observable<D>, Observable<E>> four,
1421-
final Function<Observable<E>, Observable<F>> five,
1422-
final Function<Observable<F>, Observable<G>> six,
1423-
final Function<Observable<G>, Observable<H>> seven,
1424-
final Function<Observable<H>, Observable<I>> eight,
1425-
final Function<Observable<I>, Observable<R>> nine) throws Exception {
1418+
final ObservableTransformer<A, B> one,
1419+
final ObservableTransformer<B, C> two,
1420+
final ObservableTransformer<C, D> three,
1421+
final ObservableTransformer<D, E> four,
1422+
final ObservableTransformer<E, F> five,
1423+
final ObservableTransformer<F, G> six,
1424+
final ObservableTransformer<G, H> seven,
1425+
final ObservableTransformer<H, I> eight,
1426+
final ObservableTransformer<I, R> nine) throws Exception {
14261427
return zero.call()
14271428
.compose(one)
14281429
.compose(two)

rxcomprehensions2/src/test/java/com/pacoworks/rxcomprehensions/RxComprehensionsTest.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import java.util.concurrent.Callable;
2323

2424
import io.reactivex.Observable;
25+
import io.reactivex.ObservableSource;
26+
import io.reactivex.ObservableTransformer;
2527
import io.reactivex.functions.BiFunction;
2628
import io.reactivex.functions.Function;
2729
import io.reactivex.functions.Function3;
@@ -322,11 +324,11 @@ public Observable<Object> apply(Integer integer, Boolean aBoolean, String s, Str
322324
};
323325
}
324326

325-
private Function<Observable<Integer>, Observable<String>> intIncrementToString() {
326-
return new Function<Observable<Integer>, Observable<String>>() {
327+
private ObservableTransformer<Integer, String> intIncrementToString() {
328+
return new ObservableTransformer<Integer, String>() {
327329
@Override
328-
public Observable<String> apply(Observable<Integer> integerObservable) throws Exception {
329-
return integerObservable.map(new Function<Integer, String>() {
330+
public ObservableSource<String> apply(Observable<Integer> upstream) {
331+
return upstream.map(new Function<Integer, String>() {
330332
@Override
331333
public String apply(Integer integer) throws Exception {
332334
return Integer.toString(integer + 1);
@@ -336,11 +338,11 @@ public String apply(Integer integer) throws Exception {
336338
};
337339
}
338340

339-
private Function<Observable<String>, Observable<Integer>> stringToInt() {
340-
return new Function<Observable<String>, Observable<Integer>>() {
341+
private ObservableTransformer<String, Integer> stringToInt() {
342+
return new ObservableTransformer<String, Integer>() {
341343
@Override
342-
public Observable<Integer> apply(Observable<String> stringObservable) throws Exception {
343-
return stringObservable.map(new Function<String, Integer>() {
344+
public ObservableSource<Integer> apply(Observable<String> upstream) {
345+
return upstream.map(new Function<String, Integer>() {
344346
@Override
345347
public Integer apply(String s) throws Exception {
346348
return Integer.parseInt(s);

0 commit comments

Comments
 (0)