Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.5.0 #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requires-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ waitress>=1.4.4
multiprocess>=0.70.12
psutil>=5.8.0
dash_testing_stub>=0.0.2
urllib3>=2.5.0 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

@gemini-code-assist gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade of urllib3 to version 2.5.0 will cause dependency conflicts and break the installation of testing requirements.

The requests library versions prior to 2.32.0 are not compatible with urllib3>=2.0. The current requirement in this file is requests[security]>=2.21.0 (on line 7), which allows incompatible versions of requests (e.g., 2.31.0 as hinted at in the PR description) to be chosen by pip.

When pip tries to resolve dependencies, it will face a conflict:

  • requests<2.32.0 requires urllib3<2.0
  • This PR adds a requirement for urllib3>=2.5.0

To fix this, the requests dependency on line 7 must also be updated to a version that supports urllib3 v2. I recommend updating line 7 to:

requests[security]>=2.32.0

This will ensure a compatible version of requests is installed along with the upgraded urllib3.