Skip to content

[Snyk] Security upgrade requests from 2.31.0 to 2.32.4 #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Snyk] Security upgrade requests from 2.31.0 to 2.32.4 #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requires-testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ cryptography<3.4;python_version<"3.7"
lxml>=4.6.2
percy>=2.0.2
pytest>=6.0.2
requests[security]>=2.21.0
requests>=2.32.4
Copy link

@gemini-code-assist gemini-code-assist bot Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The upgrade to requests>=2.32.4 also removes the [security] extra. This extra previously installed pyOpenSSL and cryptography (among others like idna and certifi, which are now dependencies of the base requests package).

While requests on Python 3.8+ (as used in this project, specified by python_requires=">=3.8" in setup.py) has robust built-in SSL/TLS support via the standard ssl module, pyOpenSSL can offer different capabilities (e.g., additional cipher suites, different TLS negotiation behavior, or specific client certificate handling) by injecting itself into urllib3 (which requests uses).

Please verify that all testing scenarios, especially those involving HTTPS requests to servers with specific or non-standard TLS configurations, continue to pass. If any tests relied on features uniquely provided by pyOpenSSL, then pyOpenSSL (and potentially cryptography) might need to be added as explicit dependencies in this file.

selenium>=3.141.0,<=4.2.0
waitress>=1.4.4
multiprocess>=0.70.12
Expand Down