Skip to content

Update to renamed v1.12 global method table #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2025
Merged

Update to renamed v1.12 global method table #48

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14a2a4f
Use new 1.12 name for global method table
nickrobinson251 Aug 7, 2025
51af7af
Bump version
nickrobinson251 Aug 7, 2025
11a9e76
Update src/Tricks.jl
nickrobinson251 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Tricks"
uuid = "410a4b4d-49e4-4fbc-ab6d-cb71b17b3775"
authors = ["Frames White"]
version = "0.1.11"
version = "0.1.12"

[compat]
julia = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion src/Tricks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function _method_table_all_edges_all_methods(f, T, world = Base.get_world_counte
mt = f.name.mt
mt_edges = Core.Compiler.vect(mt, Tuple{f,Vararg{Any}})
else
mt = Core.GlobalMethods
mt = Core.methodtable
Copy link
Owner

@oxinabox oxinabox Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about doing

mt = hasproperty(Core, :GlobalMethods) ? Core.GlobalMethods : Core.methodtable  # was called this in 1.12-dev/1.12-rc1 before changed in 1.12-rc2

So we don't have to worry about going back and remembering this.

Copy link
Collaborator Author

@nickrobinson251 nickrobinson251 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo yes that's better - thanks!

mt_edges = Core.Compiler.vect(Tuple{f, Vararg{Any}}, mt)
end

Expand Down
Loading