Skip to content

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Nov 7, 2025

Simplify oximeter histogram responses to show the estimates for each quantile, rather than details of the P² algorithm.

Part of #9345.

Notes:

  • If we're only showing the quantile estimates and not other details of the algorithm, we could also simplify our clickhouse queries for histograms. We can add this here, or get to it separately later on.
  • This is technically a breaking change, in the event that customers are using quantile fields in histograms—although I'm inclined to doubt they are, because I don't think we document how to use those fields. Not sure if this is a problem, but wanted to note it.

@jmcarp jmcarp requested a review from bnaecker November 7, 2025 17:07
Simplify oximeter histogram responses to show the estimates for each quantile,
rather than details of the P² algorithm.
We only want to change serialization for oximeter api responses, not messages
sent from producers to consumers. Move the custom serializer from the histogram
type to distribution.
@jmcarp jmcarp force-pushed the jmcarp/simplify-oxql-histograms branch from 06da474 to 69d52a0 Compare November 10, 2025 15:20
@jmcarp jmcarp merged commit cc8b868 into main Nov 10, 2025
17 checks passed
@jmcarp jmcarp deleted the jmcarp/simplify-oxql-histograms branch November 10, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants