From ad27b20dc399e161fa936c03b0891513a731c5ca Mon Sep 17 00:00:00 2001 From: Boshen <1430279+Boshen@users.noreply.github.com> Date: Sat, 7 Dec 2024 17:30:45 +0000 Subject: [PATCH] fix(linter): only resolve esm files for import plugin (#7720) closes #7696 cjs files do not work at all. --- crates/oxc_linter/src/rules/import/namespace.rs | 4 ++++ crates/oxc_linter/src/service/runtime.rs | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/crates/oxc_linter/src/rules/import/namespace.rs b/crates/oxc_linter/src/rules/import/namespace.rs index e4ac697919168..74431454a1b3a 100644 --- a/crates/oxc_linter/src/rules/import/namespace.rs +++ b/crates/oxc_linter/src/rules/import/namespace.rs @@ -156,6 +156,10 @@ impl Rule for Namespace { } }; + if !module.has_module_syntax { + return; + } + let Some(symbol_id) = ctx.scopes().get_root_binding(entry.local_name.name()) else { return; }; diff --git a/crates/oxc_linter/src/service/runtime.rs b/crates/oxc_linter/src/service/runtime.rs index 87ba57824759e..8014df9f582fc 100644 --- a/crates/oxc_linter/src/service/runtime.rs +++ b/crates/oxc_linter/src/service/runtime.rs @@ -69,7 +69,8 @@ impl Runtime { }); Resolver::new(ResolveOptions { extensions: VALID_EXTENSIONS.iter().map(|ext| format!(".{ext}")).collect(), - condition_names: vec!["module".into(), "require".into()], + main_fields: vec!["module".into(), "main".into()], + condition_names: vec!["module".into(), "import".into()], extension_alias, tsconfig, ..ResolveOptions::default()