fix(apps,napi): explicitly specify libs in tsconfigs (#20071)

camc314 · camc314 · commit ee0491e93763 · 2026-03-06T14:46:23.000Z
Replaces #20064 The `dom` lib was implicitly being injected, this means stuff like `Token` and `Comment` were in the global scope, which was incorrect. cc @overlookmotel
diff --git a/.gitignore b/.gitignore
@@ -18,6 +18,7 @@ target/
 /tasks/e2e/tests/nestjs/node_modules/
 /npm/*/node_modules
 /napi/*/npm-dir
+/napi/parser/tsconfig.browser.tsbuildinfo
 
 # Cloned conformance repos
 tasks/coverage/babel/
diff --git a/apps/oxfmt/tsconfig.json b/apps/oxfmt/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "lib": ["ESNext"],
     "module": "Preserve",
     "moduleResolution": "Bundler",
     "noEmit": true,
diff --git a/apps/oxlint/tsconfig.json b/apps/oxlint/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "lib": ["ESNext"],
     "module": "Preserve",
     "moduleResolution": "Bundler",
     "noEmit": true,
diff --git a/napi/minify/tsconfig.json b/napi/minify/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "lib": ["ESNext"],
     "module": "Preserve",
     "moduleResolution": "Bundler",
     "noEmit": true,
diff --git a/napi/parser/tsconfig.browser.json b/napi/parser/tsconfig.browser.json
@@ -0,0 +1,19 @@
+{
+  "extends": "./tsconfig.node.json",
+  "compilerOptions": {
+    "composite": true,
+    "declaration": true,
+    "emitDeclarationOnly": true,
+    "declarationDir": "./.tsbuild/browser",
+    "lib": [
+      "ESNext",
+      "DOM",
+      "DOM.Iterable",
+      "DOM.AsyncIterable",
+      "WebWorker.ImportScripts",
+      "ScriptHost"
+    ]
+  },
+  "include": ["test-browser/**/*.ts", "vitest.config.browser.ts"],
+  "exclude": []
+}
diff --git a/napi/parser/tsconfig.json b/napi/parser/tsconfig.json
@@ -1,11 +1,4 @@
 {
-  "compilerOptions": {
-    "module": "Preserve",
-    "moduleResolution": "Bundler",
-    "noEmit": true,
-    "target": "ESNext",
-    "allowImportingTsExtensions": true,
-    "noUnusedLocals": true,
-    "strict": false
-  }
+  "files": [],
+  "references": [{ "path": "./tsconfig.node.json" }, { "path": "./tsconfig.browser.json" }]
 }
diff --git a/napi/parser/tsconfig.node.json b/napi/parser/tsconfig.node.json
@@ -0,0 +1,14 @@
+{
+  "compilerOptions": {
+    "lib": ["ESNext"],
+    "module": "Preserve",
+    "moduleResolution": "Bundler",
+    "noEmit": true,
+    "target": "ESNext",
+    "allowImportingTsExtensions": true,
+    "noUnusedLocals": true,
+    "skipLibCheck": true,
+    "strict": false
+  },
+  "exclude": ["test-browser", "vitest.config.browser.ts"]
+}
diff --git a/napi/transform/tsconfig.json b/napi/transform/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "lib": ["ESNext"],
     "module": "Preserve",
     "moduleResolution": "Bundler",
     "noEmit": true,

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
	`3`	`+ "lib": ["ESNext"],`
`3`	`4`	`"module": "Preserve",`
`4`	`5`	`"moduleResolution": "Bundler",`
`5`	`6`	`"noEmit": true,`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,4 @@`
`1`	`1`	`{`
`2`		`- "compilerOptions": {`
`3`		`- "module": "Preserve",`
`4`		`- "moduleResolution": "Bundler",`
`5`		`- "noEmit": true,`
`6`		`- "target": "ESNext",`
`7`		`- "allowImportingTsExtensions": true,`
`8`		`- "noUnusedLocals": true,`
`9`		`- "strict": false`
`10`		`- }`
	`2`	`+ "files": [],`
	`3`	`+ "references": [{ "path": "./tsconfig.node.json" }, { "path": "./tsconfig.browser.json" }]`
`11`	`4`	`}`