fix(transformer/legacy-decorator): abstract class doesn't work in metadata

Author: Dunqing

crates/oxc_transformer/src/decorator/legacy/metadata.rs

@@ -107,7 +107,7 @@ impl<'a, 'ctx> LegacyDecoratorMetadata<'a, 'ctx> {
 
 impl<'a> Traverse<'a> for LegacyDecoratorMetadata<'a, '_> {
     fn enter_class(&mut self, class: &mut Class<'a>, ctx: &mut TraverseCtx<'a>) {
-        if class.is_expression() || class.is_typescript_syntax() {
+        if class.is_expression() || class.declare {
             return;
         }
 

crates/oxc_transformer/src/decorator/legacy/mod.rs

@@ -808,7 +808,7 @@ impl<'a> LegacyDecorator<'a, '_> {
     /// Check if a class or its elements have decorators.
     fn check_class_has_decorated(class: &Class<'a>) -> ClassDecoratorInfo {
         // Legacy decorator does not allow in class expression.
-        if class.is_expression() || class.is_typescript_syntax() {
+        if class.is_expression() || class.declare {
             return ClassDecoratorInfo::default();
         }
 

tasks/transform_conformance/snapshots/oxc.snap.md

@@ -1,6 +1,6 @@
 commit: 578ac4df
 
-Passed: 152/253
+Passed: 152/254
 
 # All Passed:
 * babel-plugin-transform-class-static-block
@@ -497,7 +497,18 @@ after transform: SymbolId(4): ScopeId(1)
 rebuilt        : SymbolId(5): ScopeId(4)
 
 
-# legacy-decorators (4/73)
+# legacy-decorators (4/74)
+* oxc/metadata/abstrct-class/input.ts
+Bindings mismatch:
+after transform: ScopeId(0): ["AbstractClass", "Dependency", "dce"]
+rebuilt        : ScopeId(0): ["AbstractClass", "dce"]
+Symbol span mismatch for "AbstractClass":
+after transform: SymbolId(2): Span { start: 74, end: 87 }
+rebuilt        : SymbolId(1): Span { start: 0, end: 0 }
+Symbol span mismatch for "AbstractClass":
+after transform: SymbolId(4): Span { start: 0, end: 0 }
+rebuilt        : SymbolId(2): Span { start: 74, end: 87 }
+
 * oxc/metadata/bound-type-reference/input.ts
 Symbol reference IDs mismatch for "BoundTypeReference":
 after transform: SymbolId(0): [ReferenceId(1), ReferenceId(3), ReferenceId(4), ReferenceId(5), ReferenceId(6)]

tasks/transform_conformance/tests/legacy-decorators/test/fixtures/oxc/metadata/abstrct-class/input.ts

@@ -0,0 +1,6 @@
+import { dce, type Dependency } from "mod";
+
+@dce()
+export abstract class AbstractClass {
+	constructor(public dependency: Dependency) {}
+}

tasks/transform_conformance/tests/legacy-decorators/test/fixtures/oxc/metadata/abstrct-class/output.ts

@@ -0,0 +1,11 @@
+import { dce } from "mod";
+let AbstractClass = class AbstractClass {
+	constructor(dependency) {
+		this.dependency = dependency;
+	}
+};
+AbstractClass = babelHelpers.decorate(
+	[dce(), babelHelpers.decorateMetadata("design:paramtypes", [Object])],
+	AbstractClass,
+);
+export { AbstractClass };