Skip to content

Commit b2f3d23

Browse files
committed
refactor(isolated_declarations): remove unused self params (#9868)
Pure refactor / code clean up. Remove `&self` from method params where it's not used.
1 parent eef7eb6 commit b2f3d23

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

crates/oxc_isolated_declarations/src/class.rs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ use crate::{
1414
};
1515

1616
impl<'a> IsolatedDeclarations<'a> {
17-
#[expect(clippy::unused_self)]
18-
pub(crate) fn is_literal_key(&self, key: &PropertyKey<'a>) -> bool {
17+
pub(crate) fn is_literal_key(key: &PropertyKey<'a>) -> bool {
1918
match key {
2019
PropertyKey::StringLiteral(_)
2120
| PropertyKey::NumericLiteral(_)
@@ -55,17 +54,15 @@ impl<'a> IsolatedDeclarations<'a> {
5554
}
5655

5756
pub(crate) fn report_property_key(&self, key: &PropertyKey<'a>) -> bool {
58-
if !self.is_literal_key(key) && !Self::is_global_symbol(key) {
57+
if !Self::is_literal_key(key) && !Self::is_global_symbol(key) {
5958
self.error(computed_property_name(key.span()));
6059
true
6160
} else {
6261
false
6362
}
6463
}
6564

66-
#[expect(clippy::unused_self)]
6765
pub(crate) fn transform_accessibility(
68-
&self,
6966
accessibility: Option<TSAccessibility>,
7067
) -> Option<TSAccessibility> {
7168
if accessibility.is_none() || accessibility.is_some_and(|a| a == TSAccessibility::Public) {
@@ -126,7 +123,7 @@ impl<'a> IsolatedDeclarations<'a> {
126123
property.definite,
127124
property.readonly,
128125
type_annotations,
129-
self.transform_accessibility(property.accessibility),
126+
Self::transform_accessibility(property.accessibility),
130127
)
131128
}
132129

@@ -163,7 +160,7 @@ impl<'a> IsolatedDeclarations<'a> {
163160
definition.r#static,
164161
definition.r#override,
165162
definition.optional,
166-
self.transform_accessibility(definition.accessibility),
163+
Self::transform_accessibility(definition.accessibility),
167164
)
168165
}
169166

@@ -218,7 +215,7 @@ impl<'a> IsolatedDeclarations<'a> {
218215
false,
219216
param.readonly,
220217
type_annotation,
221-
self.transform_accessibility(param.accessibility),
218+
Self::transform_accessibility(param.accessibility),
222219
))
223220
}
224221

@@ -239,7 +236,7 @@ impl<'a> IsolatedDeclarations<'a> {
239236
method.key.clone_in(self.ast.allocator),
240237
method.r#static,
241238
method.r#override,
242-
self.transform_accessibility(method.accessibility),
239+
Self::transform_accessibility(method.accessibility),
243240
)
244241
}
245242
MethodDefinitionKind::Get | MethodDefinitionKind::Constructor => {
@@ -305,7 +302,7 @@ impl<'a> IsolatedDeclarations<'a> {
305302
if let ClassElement::MethodDefinition(method) = element {
306303
if (method.key.is_private_identifier()
307304
|| method.accessibility.is_some_and(TSAccessibility::is_private))
308-
|| (method.computed && !self.is_literal_key(&method.key))
305+
|| (method.computed && !Self::is_literal_key(&method.key))
309306
{
310307
continue;
311308
}

crates/oxc_isolated_declarations/src/declaration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ impl<'a> IsolatedDeclarations<'a> {
232232
PropertyKey::StaticMemberExpression(expr) => {
233233
!expr.get_first_object().is_identifier_reference()
234234
}
235-
key => !self.is_literal_key(key),
235+
key => !Self::is_literal_key(key),
236236
};
237237

238238
if is_not_allowed {

crates/oxc_isolated_declarations/src/enum.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ impl<'a> IsolatedDeclarations<'a> {
104104
self.evaluate(expr, enum_name, prev_members)
105105
}
106106

107-
#[expect(clippy::unused_self)]
108107
fn evaluate_ref(
109-
&self,
110108
expr: &Expression<'a>,
111109
enum_name: &str,
112110
prev_members: &FxHashMap<Atom<'a>, ConstantValue>,
@@ -150,7 +148,7 @@ impl<'a> IsolatedDeclarations<'a> {
150148
| Expression::ComputedMemberExpression(_)
151149
| Expression::StaticMemberExpression(_)
152150
| Expression::PrivateFieldExpression(_) => {
153-
self.evaluate_ref(expr, enum_name, prev_members)
151+
Self::evaluate_ref(expr, enum_name, prev_members)
154152
}
155153
Expression::BinaryExpression(expr) => {
156154
self.eval_binary_expression(expr, enum_name, prev_members)

0 commit comments

Comments
 (0)