chore(infra): dogfooding oxfmt (#14979)

Fixes #14803

- Added `oxfmt` and `oxfmtrc.jsonc`
- Remove `dprint` plugin and useless ignore paths
- Apply `dprint` again
- Apply `oxfmt`

Author: leaysgur

.github/scripts/generate-benchmark-matrix.js

@@ -31,7 +31,7 @@ function checkGlobalChanges(changedFiles) {
   }
 
   for (const file of changedFiles) {
-    if (GLOBAL_FILES.some(globalFile => file === globalFile || file.endsWith(`/${globalFile}`))) {
+    if (GLOBAL_FILES.some((globalFile) => file === globalFile || file.endsWith(`/${globalFile}`))) {
       console.error(`Global file changed: ${file}`);
       return true;
     }
@@ -89,14 +89,14 @@ function isComponentAffected(component, changedFiles) {
   // Check if any dependency files changed
   for (const dep of dependencies) {
     const depPath = `crates/${dep}/`;
-    if (changedFiles.some(file => file.startsWith(depPath))) {
+    if (changedFiles.some((file) => file.startsWith(depPath))) {
       console.error(`  Component ${component} affected by changes in ${depPath}`);
       return true;
     }
   }
 
   // Check benchmark and common task files
-  if (changedFiles.some(file => file.startsWith('tasks/benchmark/') || file.startsWith('tasks/common/'))) {
+  if (changedFiles.some((file) => file.startsWith('tasks/benchmark/') || file.startsWith('tasks/common/'))) {
     console.error(`  Component ${component} affected by benchmark/common file changes`);
     return true;
   }
@@ -113,7 +113,7 @@ async function determineAffectedComponents() {
 
   // Manual trigger - run all benchmarks
   if (changedFiles === null) {
-    return ALL_COMPONENTS.map(component => ({
+    return ALL_COMPONENTS.map((component) => ({
       component,
       feature: getFeatureForComponent(component),
     }));
@@ -122,7 +122,7 @@ async function determineAffectedComponents() {
   // Check for global changes
   if (checkGlobalChanges(changedFiles)) {
     console.error('Global changes detected - will run all benchmarks');
-    return ALL_COMPONENTS.map(component => ({
+    return ALL_COMPONENTS.map((component) => ({
       component,
       feature: getFeatureForComponent(component),
     }));
@@ -144,7 +144,7 @@ async function determineAffectedComponents() {
   if (affectedComponents.length === 0) {
     console.error('\nNo components were affected by the changes');
   } else {
-    console.error(`\nAffected components: ${affectedComponents.map(obj => obj.component).join(', ')}`);
+    console.error(`\nAffected components: ${affectedComponents.map((obj) => obj.component).join(', ')}`);
   }
 
   return affectedComponents;
@@ -165,15 +165,15 @@ async function main() {
     if (affectedComponents.length === 0) {
       console.error('::notice title=No benchmarks to run::No components were affected by the changes');
     } else {
-      const componentNames = affectedComponents.map(obj => obj.component).join(', ');
+      const componentNames = affectedComponents.map((obj) => obj.component).join(', ');
       console.error(`::notice title=Running benchmarks::Affected components: ${componentNames}`);
     }
 
     process.exit(0);
   } catch (error) {
     console.error('Error generating benchmark matrix:', error);
     // On error, run all benchmarks as a fallback
-    const fallbackMatrix = ALL_COMPONENTS.map(component => ({
+    const fallbackMatrix = ALL_COMPONENTS.map((component) => ({
       component,
       feature: getFeatureForComponent(component),
     }));

.github/scripts/get-changed-files.js

@@ -20,7 +20,7 @@ function githubApi(path) {
       path,
       headers: {
         'User-Agent': 'oxc-changed-files',
-        'Accept': 'application/vnd.github.v3+json',
+        Accept: 'application/vnd.github.v3+json',
       },
     };
 
@@ -30,17 +30,19 @@ function githubApi(path) {
       options.headers['Authorization'] = `token ${token}`;
     }
 
-    https.get(options, (res) => {
-      let data = '';
-      res.on('data', chunk => data += chunk);
-      res.on('end', () => {
-        if (res.statusCode === 200) {
-          resolve(JSON.parse(data));
-        } else {
-          reject(new Error(`GitHub API error: ${res.statusCode} ${data}`));
-        }
-      });
-    }).on('error', reject);
+    https
+      .get(options, (res) => {
+        let data = '';
+        res.on('data', (chunk) => (data += chunk));
+        res.on('end', () => {
+          if (res.statusCode === 200) {
+            resolve(JSON.parse(data));
+          } else {
+            reject(new Error(`GitHub API error: ${res.statusCode} ${data}`));
+          }
+        });
+      })
+      .on('error', reject);
   });
 }
 
@@ -72,12 +74,12 @@ async function getChangedFiles() {
       // For PR, use GitHub API to get changed files
       console.error(`Getting changed files for PR #${prNumber}`);
       const prFiles = await githubApi(`/repos/${repository}/pulls/${prNumber}/files?per_page=100`);
-      files = prFiles.map(f => f.filename);
+      files = prFiles.map((f) => f.filename);
     } else if (sha && repository) {
       // For push to main, get the commit and compare with parent
       console.error(`Getting changed files for commit ${sha}`);
       const commit = await githubApi(`/repos/${repository}/commits/${sha}`);
-      files = commit.files ? commit.files.map(f => f.filename) : [];
+      files = commit.files ? commit.files.map((f) => f.filename) : [];
     } else {
       // No valid parameters for API calls
       console.error('Error: Missing required environment variables for GitHub API');
@@ -91,7 +93,7 @@ async function getChangedFiles() {
   }
 
   console.error(`Changed files (${files.length}):`);
-  files.forEach(f => console.error(`  - ${f}`));
+  files.forEach((f) => console.error(`  - ${f}`));
 
   return files;
 }
@@ -101,11 +103,11 @@ module.exports = { getChangedFiles };
 // If run directly as a script, output changed files as JSON
 if (require.main === module) {
   getChangedFiles()
-    .then(files => {
+    .then((files) => {
       console.log(JSON.stringify(files));
       process.exit(0);
     })
-    .catch(error => {
+    .catch((error) => {
       console.error('Error:', error);
       console.log(JSON.stringify(null));
       process.exit(1);

.github/scripts/utils.js

@@ -29,7 +29,7 @@ function exec(command) {
  */
 function getCrateDependencies(packages, options = {}) {
   const pkgs = Array.isArray(packages) ? packages : [packages];
-  const packageArgs = pkgs.map(pkg => `-p ${pkg}`).join(' ');
+  const packageArgs = pkgs.map((pkg) => `-p ${pkg}`).join(' ');
 
   let command = `cargo tree ${packageArgs} -f "{lib}" -e normal --no-dedupe --prefix none`;
 
@@ -51,7 +51,7 @@ function getCrateDependencies(packages, options = {}) {
   }
 
   // Filter out the queried packages themselves
-  return output.split('\n').filter(dep => dep && !pkgs.includes(dep));
+  return output.split('\n').filter((dep) => dep && !pkgs.includes(dep));
 }
 
 /**
@@ -69,15 +69,15 @@ function checkFilesAffectCrates(changedFiles, crates, additionalPaths = []) {
   // Check if any changed file affects a crate
   for (const crate of crates) {
     const cratePath = `crates/${crate}/`;
-    if (changedFiles.some(file => file.startsWith(cratePath))) {
+    if (changedFiles.some((file) => file.startsWith(cratePath))) {
       console.error(`File affects crate ${crate}`);
       return true;
     }
   }
 
   // Check additional paths
   for (const path of additionalPaths) {
-    if (changedFiles.some(file => file.startsWith(path))) {
+    if (changedFiles.some((file) => file.startsWith(path))) {
       console.error(`File affects path ${path}`);
       return true;
     }

.github/workflows/autofix.yml

@@ -19,6 +19,8 @@ jobs:
     steps:
       - uses: taiki-e/checkout-action@b13d20b7cda4e2f325ef19895128f7ff735c0b3d # v1.3.1
 
+      - uses: oxc-project/setup-node@fdbf0dfd334c4e6d56ceeb77d91c76339c2a0885 # v1.0.4
+
       - name: Restore dprint plugin cache
         id: cache-restore
         uses: actions/cache/restore@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0

apps/oxlint/src-js/index.ts

@@ -87,7 +87,9 @@ export function defineRule(rule: Rule): Rule {
   if ('create' in rule) return rule;
 
   // Add `create` function to `rule`
-  let context: Context = null, visitor: Visitor, beforeHook: BeforeHook | null;
+  let context: Context = null,
+    visitor: Visitor,
+    beforeHook: BeforeHook | null;
 
   rule.create = (eslintContext) => {
     // Lazily call `createOnce` on first invocation of `create`
@@ -155,12 +157,13 @@ function createContextAndVisitor(rule: CreateOnceRule): {
     if (typeof afterHook !== 'function') throw new Error('`after` property of visitor must be a function if defined');
 
     const programExit = visitor['Program:exit'];
-    visitor['Program:exit'] = programExit == null
-      ? (_node) => afterHook()
-      : (node) => {
-        programExit(node);
-        afterHook();
-      };
+    visitor['Program:exit'] =
+      programExit == null
+        ? (_node) => afterHook()
+        : (node) => {
+            programExit(node);
+            afterHook();
+          };
   }
 
   return { context, visitor, beforeHook };

apps/oxlint/src-js/plugins/comments.ts

@@ -48,7 +48,7 @@ export function getCommentsBefore(nodeOrToken: NodeOrToken): Comment[] {
   let sliceEnd = 0;
 
   // Binary search for the comment immediately before `nodeOrToken`.
-  for (let lo = 0, hi = commentsLength; lo < hi;) {
+  for (let lo = 0, hi = commentsLength; lo < hi; ) {
     const mid = (lo + hi) >> 1;
     if (comments[mid].end <= targetStart) {
       sliceEnd = lo = mid + 1;
@@ -103,7 +103,7 @@ export function getCommentsAfter(nodeOrToken: NodeOrToken): Comment[] {
   let sliceEnd = 0;
 
   // Binary search for the comment immediately after `nodeOrToken`.
-  for (let lo = 0, hi = commentsLength; lo < hi;) {
+  for (let lo = 0, hi = commentsLength; lo < hi; ) {
     const mid = (lo + hi) >> 1;
     if (comments[mid].start < targetEnd) {
       lo = mid + 1;
@@ -147,7 +147,7 @@ export function getCommentsInside(node: Node): Comment[] {
     rangeEnd = range[1];
 
   // Binary search for first comment within `node`'s range.
-  for (let lo = 0, hi = commentsLength; lo < hi;) {
+  for (let lo = 0, hi = commentsLength; lo < hi; ) {
     const mid = (lo + hi) >> 1;
     if (comments[mid].start < rangeStart) {
       lo = mid + 1;
@@ -158,7 +158,7 @@ export function getCommentsInside(node: Node): Comment[] {
 
   // Binary search for first comment outside `node`'s range.
   // Its index is used as `sliceEnd`, which is exclusive of the slice.
-  for (let lo = sliceStart, hi = commentsLength; lo < hi;) {
+  for (let lo = sliceStart, hi = commentsLength; lo < hi; ) {
     const mid = (lo + hi) >> 1;
     if (comments[mid].start < rangeEnd) {
       lo = mid + 1;
@@ -185,7 +185,7 @@ export function commentsExistBetween(nodeOrToken1: NodeOrToken, nodeOrToken2: No
     betweenRangeStart = nodeOrToken1.range[1];
   let firstCommentBetween = -1;
 
-  for (let lo = 0, hi = commentsLength; lo < hi;) {
+  for (let lo = 0, hi = commentsLength; lo < hi; ) {
     const mid = (lo + hi) >> 1;
     if (comments[mid].start < betweenRangeStart) {
       lo = mid + 1;
@@ -194,6 +194,9 @@ export function commentsExistBetween(nodeOrToken1: NodeOrToken, nodeOrToken2: No
     }
   }
   // Check if it ends before `nodeOrToken2` starts.
-  return 0 <= firstCommentBetween && firstCommentBetween < commentsLength &&
-    comments[firstCommentBetween].end <= nodeOrToken2.range[0];
+  return (
+    0 <= firstCommentBetween &&
+    firstCommentBetween < commentsLength &&
+    comments[firstCommentBetween].end <= nodeOrToken2.range[0]
+  );
 }

apps/oxlint/src-js/plugins/context.ts

@@ -49,11 +49,7 @@ export const diagnostics: DiagnosticReport[] = [];
  * @param ruleIndex - Index of this rule within `ruleIds` passed from Rust
  * @param filePath - Absolute path of file being linted
  */
-export let setupContextForFile: (
-  context: Context,
-  ruleIndex: number,
-  filePath: string,
-) => void;
+export let setupContextForFile: (context: Context, ruleIndex: number, filePath: string) => void;
 
 /**
  * Get internal data from `Context`.
@@ -138,7 +134,7 @@ export class Context {
   // Getter for current working directory.
   get cwd() {
     getInternal(this, 'access `context.cwd`');
-    return cachedCwd ??= process.cwd();
+    return (cachedCwd ??= process.cwd());
   }
 
   // Getter for options for file being linted.
@@ -201,8 +197,12 @@ export class Context {
       // Do type validation checks here, to ensure no error in serialization / deserialization.
       // Range validation happens on Rust side.
       if (
-        typeof start !== 'number' || typeof end !== 'number' ||
-        start < 0 || end < 0 || (start | 0) !== start || (end | 0) !== end
+        typeof start !== 'number' ||
+        typeof end !== 'number' ||
+        start < 0 ||
+        end < 0 ||
+        (start | 0) !== start ||
+        (end | 0) !== end
       ) {
         throw new TypeError('`node.range[0]` and `node.range[1]` must be non-negative integers');
       }
@@ -270,9 +270,9 @@ function resolveMessageFromMessageId(messageId: string, internal: InternalContex
 
   if (!hasOwn(messages, messageId)) {
     throw new Error(
-      `Unknown messageId '${messageId}'. Available \`messageIds\`: ${
-        ObjectKeys(messages).map((msg) => `'${msg}'`).join(', ')
-      }`,
+      `Unknown messageId '${messageId}'. Available \`messageIds\`: ${ObjectKeys(messages)
+        .map((msg) => `'${msg}'`)
+        .join(', ')}`,
     );
   }
 

apps/oxlint/src-js/plugins/fix.ts

@@ -170,8 +170,11 @@ function validateAndConformFix(fix: unknown): Fix {
   // Note: `ownKeys(fix).length === 2` rules out `fix` having a custom `toJSON` method.
   const fixPrototype = getPrototypeOf(fix);
   if (
-    (fixPrototype === ObjectPrototype || fixPrototype === null) && ownKeys(fix).length === 2 &&
-    getPrototypeOf(range) === ArrayPrototype && !hasOwn(range, 'toJSON') && range.length === 2 &&
+    (fixPrototype === ObjectPrototype || fixPrototype === null) &&
+    ownKeys(fix).length === 2 &&
+    getPrototypeOf(range) === ArrayPrototype &&
+    !hasOwn(range, 'toJSON') &&
+    range.length === 2 &&
     typeof text === 'string'
   ) {
     return fix;

apps/oxlint/src-js/plugins/location.ts

@@ -37,11 +37,13 @@ export function initLines(): void {
    */
 
   // Note: `lineStartOffsets` starts as `[0]`
-  let lastOffset = 0, offset, match;
+  let lastOffset = 0,
+    offset,
+    match;
   while ((match = LINE_BREAK_PATTERN.exec(sourceText))) {
     offset = match.index;
     lines.push(sourceText.slice(lastOffset, offset));
-    lineStartOffsets.push(lastOffset = offset + match[0].length);
+    lineStartOffsets.push((lastOffset = offset + match[0].length));
   }
   lines.push(sourceText.slice(lastOffset));
 }
@@ -89,7 +91,9 @@ export function getLineColumnFromOffset(offset: number): LineColumn {
  */
 function getLineColumnFromOffsetUnchecked(offset: number): LineColumn {
   // Binary search `lineStartOffsets` for the line containing `offset`
-  let low = 0, high = lineStartOffsets.length, mid: number;
+  let low = 0,
+    high = lineStartOffsets.length,
+    mid: number;
   do {
     mid = ((low + high) / 2) | 0; // Use bitwise OR to floor the division
     if (offset < lineStartOffsets[mid]) {

apps/oxlint/src-js/plugins/selector.ts

@@ -144,7 +144,7 @@ function analyzeSelector(esquerySelector: EsquerySelector, selector: Selector):
         } else {
           // Selector only matches intersection of all child selectors.
           // TODO: Could make this faster if `analyzeSelector` always returned an ordered array.
-          nodeTypes = childNodeTypes.filter(nodeType => nodeTypes.includes(nodeType));
+          nodeTypes = childNodeTypes.filter((nodeType) => nodeTypes.includes(nodeType));
         }
       }
       return nodeTypes;