fix(transformer/typescript): panic when using removeClassFieldsWithoutInitializer and private class members (#10838)

Author: camc314

crates/oxc_transformer/src/typescript/class.rs

@@ -212,7 +212,7 @@ impl<'a> TypeScript<'a, '_> {
 
         class.body.body.retain(|element| {
             if let ClassElement::PropertyDefinition(prop) = element {
-                if prop.value.is_none() {
+                if prop.value.is_none() && !prop.key.is_private_identifier() {
                     return false;
                 }
             }

tasks/transform_conformance/snapshots/oxc.snap.md

@@ -1,6 +1,6 @@
 commit: 578ac4df
 
-Passed: 152/252
+Passed: 152/253
 
 # All Passed:
 * babel-plugin-transform-class-static-block
@@ -44,7 +44,7 @@ after transform: SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(6), R
 rebuilt        : SymbolId(0): [ReferenceId(0), ReferenceId(2), ReferenceId(6), ReferenceId(10)]
 
 
-# babel-plugin-transform-typescript (4/24)
+# babel-plugin-transform-typescript (4/25)
 * allow-declare-fields-false/input.ts
 Unresolved references mismatch:
 after transform: ["dce"]
@@ -403,6 +403,11 @@ rebuilt        : []
 * ts-declaration-empty-output/input.d.ts
 x Output mismatch
 
+* ts-private-field-with-remove-class-fields-without-initializer/input.ts
+Unresolved references mismatch:
+after transform: ["ArrayBufferView", "Transferable", "WeakMap", "babelHelpers", "kTransferable", "kValue"]
+rebuilt        : ["WeakMap", "babelHelpers", "kTransferable", "kValue"]
+
 * use-define-for-class-fields/input.ts
 Unresolved references mismatch:
 after transform: ["dce"]

tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/ts-private-field-with-remove-class-fields-without-initializer/input.ts

@@ -0,0 +1,14 @@
+export class ArrayBufferViewTransferable implements Transferable {
+  #view: ArrayBufferView;
+  constructor(view: ArrayBufferView) {
+    this.#view = view;
+  }
+
+  get [kTransferable](): object {
+    return this.#view.buffer;
+  }
+
+  get [kValue](): object {
+    return this.#view;
+  }
+}

tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/ts-private-field-with-remove-class-fields-without-initializer/options.json

@@ -0,0 +1,11 @@
+{
+  "plugins": [
+    "transform-class-properties",
+    [
+      "transform-typescript",
+      {
+        "removeClassFieldsWithoutInitializer": true
+      }
+    ]
+  ]
+}

tasks/transform_conformance/tests/babel-plugin-transform-typescript/test/fixtures/ts-private-field-with-remove-class-fields-without-initializer/output.js

@@ -0,0 +1,18 @@
+let _kTransferable, _kValue;
+var _view = /* @__PURE__ */ new WeakMap();
+_kTransferable = kTransferable;
+_kValue = kValue;
+export class ArrayBufferViewTransferable {
+  constructor(view) {
+    babelHelpers.classPrivateFieldInitSpec(this, _view, void 0);
+    babelHelpers.classPrivateFieldSet2(_view, this, view);
+  }
+
+  get [_kTransferable]() {
+    return babelHelpers.classPrivateFieldGet2(_view, this).buffer;
+  }
+
+  get [_kValue]() {
+    return babelHelpers.classPrivateFieldGet2(_view, this);
+  }
+}