fix(linter): rule symbol-description do not look into globals

Sysix · Sysix · commit 8e959fb816fd · 2025-02-15T15:14:45.000+01:00
diff --git a/crates/oxc_linter/src/rules/eslint/symbol_description.rs b/crates/oxc_linter/src/rules/eslint/symbol_description.rs
@@ -59,7 +59,7 @@ impl Rule for SymbolDescription {
 
         if ident.name == "Symbol"
             && call_expr.arguments.len() == 0
-            && ctx.is_reference_to_global_variable(ident)
+            && ctx.scopes().root_unresolved_references().contains_key(ident.name.as_str())
         {
             ctx.diagnostic(symbol_description_diagnostic(call_expr.span));
         }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ impl Rule for SymbolDescription {`
`59`	`59`
`60`	`60`	`if ident.name == "Symbol"`
`61`	`61`	`&& call_expr.arguments.len() == 0`
`62`		`- && ctx.is_reference_to_global_variable(ident)`
	`62`	`+ && ctx.scopes().root_unresolved_references().contains_key(ident.name.as_str())`
`63`	`63`	`{`
`64`	`64`	`ctx.diagnostic(symbol_description_diagnostic(call_expr.span));`
`65`	`65`	`}`