fix(core): resolve path in node_modules

Author: Brooooooklyn

packages/integrate-module-bundler/package.json

@@ -23,6 +23,7 @@
     "@types/react": "^19.0.13",
     "@types/react-dom": "^19.0.5",
     "express": "^5.1.0",
+    "core-js": "^3.41.0",
     "react": "^19.1.0",
     "react-dom": "^19.1.0",
     "simple-git": "^3.27.0",

packages/integrate-module-bundler/src/index.ts

@@ -1,3 +1,6 @@
+import 'core-js/modules/esnext.symbol.async-dispose'
+import 'core-js/modules/esnext.symbol.dispose'
+
 import assert from 'node:assert'
 import test from 'node:test'
 import { createRequire } from 'node:module'
@@ -76,12 +79,18 @@ await test('resolve mts in type commonjs package', () => {
 })
 
 await test('resolve nestjs', async () => {
-  const app = await bootstrap()
+  const { app } = await bootstrap()
   const service = app.get(AppService)
   assert.equal(service.getHello(), 'Hello World!')
   await app.close()
 })
 
+await test('using syntax', async () => {
+  await using nest = await bootstrap()
+  const service = nest.app.get(AppService)
+  assert.equal(service.getHello(), 'Hello World!')
+})
+
 if (!process.versions.node.startsWith('18')) {
   await test('resolve typescript cjs', () => {
     const require = createRequire(import.meta.url)

packages/integrate-module-bundler/src/nestjs/index.ts

@@ -5,5 +5,5 @@ import { AppModule } from './app.module'
 export async function bootstrap() {
   const app = await NestFactory.create(AppModule)
   await app.listen(3000)
-  return app
+  return { app, [Symbol.asyncDispose]: async () => app.close() }
 }

pnpm-lock.yaml

@@ -21,8 +21,8 @@ use oxc::{
     },
 };
 use oxc_resolver::{
-    CompilerOptionsSerde, EnforceExtension, PackageType, ResolveOptions, Resolver, TsConfigSerde,
-    TsconfigOptions, TsconfigReferences,
+    Cache, CompilerOptionsSerde, EnforceExtension, PackageType, Resolution, ResolveOptions,
+    Resolver, TsConfigSerde, TsconfigOptions, TsconfigReferences,
 };
 use phf::Set;
 
@@ -486,16 +486,7 @@ pub fn create_resolve<'env>(
             .map(|p| p.contains(NODE_MODULES_PATH))
             .unwrap_or(false)
         {
-            #[cfg_attr(not(target_os = "windows"), allow(unused_mut))]
-            let mut url = if resolution.query().is_some() || resolution.fragment().is_some() {
-                format!("{PATH_PREFIX}{}", resolution.full_path().to_string_lossy())
-            } else {
-                format!("{PATH_PREFIX}{}", resolution.path().to_string_lossy())
-            };
-            #[cfg(target_os = "windows")]
-            {
-                url = url.replace("\\", "/");
-            }
+            let url = oxc_resolved_path_to_url(&resolution);
             return Ok(Either::A(ResolveFnOutput {
                 short_circuit: Some(true),
                 format: {
@@ -522,6 +513,29 @@ pub fn create_resolve<'env>(
                 url,
                 import_attributes: Some(Either::A(context.import_attributes.clone())),
             }));
+        } else {
+            let format = resolution
+                .package_json()
+                .and_then(|p| {
+                    p.r#type.map(|p| match p {
+                        PackageType::CommonJs => "commonjs",
+                        PackageType::Module => "module",
+                    })
+                })
+                .or_else(|| match p.extension().and_then(|ext| ext.to_str()) {
+                    Some("cjs" | "cts" | "node") => Some("commonjs"),
+                    Some("mts" | "mjs") => Some("module"),
+                    _ => None,
+                })
+                .unwrap_or("commonjs")
+                .to_string();
+            tracing::debug!("oxc resolved path node_modules: {} {}", p.display(), format);
+            return Ok(Either::A(ResolveFnOutput {
+                format: Either3::A(format),
+                short_circuit: Some(true),
+                url: oxc_resolved_path_to_url(&resolution),
+                import_attributes: Some(Either::A(context.import_attributes.clone())),
+            }));
         }
     }
 
@@ -809,3 +823,17 @@ fn join_errors(errors: Vec<OxcDiagnostic>, source_str: &str) -> String {
         .collect::<Vec<_>>()
         .join("\n")
 }
+
+fn oxc_resolved_path_to_url<C: Cache>(resolution: &Resolution<C>) -> String {
+    #[cfg_attr(not(target_os = "windows"), allow(unused_mut))]
+    let mut url = if resolution.query().is_some() || resolution.fragment().is_some() {
+        format!("{PATH_PREFIX}{}", resolution.full_path().to_string_lossy())
+    } else {
+        format!("{PATH_PREFIX}{}", resolution.path().to_string_lossy())
+    };
+    #[cfg(target_os = "windows")]
+    {
+        url = url.replace("\\", "/");
+    }
+    url
+}