-
Notifications
You must be signed in to change notification settings - Fork 183
CI platform matrix expansion #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Patch 1
|
Pardon me, given the commit history - is this a drive-by-AI PR? I suppose we could check multi arch images build, but this CI more so just checks that templated versions are correct. |
|
Nope, I wrote that code. I think AI could probably have done correctly in one commit, but no I was testing it on my own actions in my repo. I just have a use case that requires a arm64 image, and your image only supports amd64 (aka x86_64) architectures. |
Ah, can't blame you for pushed-based development with GitHub Actions. It is indeed tricky to test workflows locally.
The Official Library images for ROS on DockerHub are indeed Multi-platform builds with Are you instead wishing to use the |
|
This image was the only one that fit my needs to my knowledge. I need a development environment for ros2 with full desktop support. I realize I may have not done that correctly with this pull request and the changes I made, I am not familiar with this build system. I tried making my own image last year but it was quite challenging and not worth the time sink, and I ran into some difficult and persistent errors. |
|
A fair ask. @mikaelarguedas, this org has access to free arm builders for foss projects now, right? |
This pull request updates the GitHub Actions CI workflows to add support for running jobs on both
ubuntu-latestandubuntu-24.04-armplatforms. This change ensures that all relevant workflows are tested on both standard and ARM-based Ubuntu environments, improving cross-platform compatibility.