Skip to content

Conversation

@a1cd
Copy link

@a1cd a1cd commented Aug 25, 2025

This pull request updates the GitHub Actions CI workflows to add support for running jobs on both ubuntu-latest and ubuntu-24.04-arm platforms. This change ensures that all relevant workflows are tested on both standard and ARM-based Ubuntu environments, improving cross-platform compatibility.

@ruffsl
Copy link
Member

ruffsl commented Aug 25, 2025

Pardon me, given the commit history - is this a drive-by-AI PR?

I suppose we could check multi arch images build, but this CI more so just checks that templated versions are correct.

@a1cd
Copy link
Author

a1cd commented Aug 26, 2025

Nope, I wrote that code. I think AI could probably have done correctly in one commit, but no I was testing it on my own actions in my repo. I just have a use case that requires a arm64 image, and your image only supports amd64 (aka x86_64) architectures.
AI did write the commit titles/descriptions but thats all.

@ruffsl
Copy link
Member

ruffsl commented Aug 26, 2025

but no I was testing it on my own actions in my repo.

Ah, can't blame you for pushed-based development with GitHub Actions. It is indeed tricky to test workflows locally.

I just have a use case that requires a arm64 image, and your image only supports amd64 (aka x86_64) architectures.

The Official Library images for ROS on DockerHub are indeed Multi-platform builds with arm64v8 support:

https://github.com/docker-library/official-images/blob/8d52c53042ed840fdc468d321c5248876bfc684e/library/ros#L76-L77

Are you instead wishing to use the osrf/ros images for the desktop tags? Indeed those are still only amd64.

@a1cd
Copy link
Author

a1cd commented Aug 26, 2025

This image was the only one that fit my needs to my knowledge. I need a development environment for ros2 with full desktop support. I realize I may have not done that correctly with this pull request and the changes I made, I am not familiar with this build system. I tried making my own image last year but it was quite challenging and not worth the time sink, and I ran into some difficult and persistent errors.

@ruffsl
Copy link
Member

ruffsl commented Aug 28, 2025

A fair ask. @mikaelarguedas, this org has access to free arm builders for foss projects now, right?
I'll have to check if this'll just work^tm as expected for multi-platform registry manifests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants