Skip to content

Commit 54de655

Browse files
committed
refactor: rename CandidateListItem to CandidateItem
1 parent f5879c3 commit 54de655

7 files changed

Lines changed: 19 additions & 19 deletions

File tree

app/src/main/java/com/osfans/trime/core/Rime.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class Rime : RimeApi, RimeLifecycleOwner {
123123
override suspend fun getCandidates(
124124
startIndex: Int,
125125
limit: Int,
126-
): Array<CandidateListItem> =
126+
): Array<CandidateItem> =
127127
withRimeContext {
128128
getRimeCandidates(startIndex, limit) ?: emptyArray()
129129
}
@@ -475,7 +475,7 @@ class Rime : RimeApi, RimeLifecycleOwner {
475475
external fun getRimeCandidates(
476476
startIndex: Int,
477477
limit: Int,
478-
): Array<CandidateListItem>?
478+
): Array<CandidateItem>?
479479

480480
/** call from rime_jni */
481481
@JvmStatic

app/src/main/java/com/osfans/trime/core/RimeApi.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ interface RimeApi {
5151
suspend fun getCandidates(
5252
startIndex: Int,
5353
limit: Int,
54-
): Array<CandidateListItem>
54+
): Array<CandidateItem>
5555
}

app/src/main/java/com/osfans/trime/core/Structs.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ data class SchemaItem(
99
val name: String = "",
1010
)
1111

12-
data class CandidateListItem(
12+
data class CandidateItem(
1313
val comment: String,
1414
val text: String,
1515
)

app/src/main/java/com/osfans/trime/ime/symbol/CandidateAdapter.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import androidx.constraintlayout.widget.ConstraintLayout
1515
import androidx.core.view.updateLayoutParams
1616
import androidx.recyclerview.widget.RecyclerView
1717
import com.chad.library.adapter4.BaseQuickAdapter
18-
import com.osfans.trime.core.CandidateListItem
18+
import com.osfans.trime.core.CandidateItem
1919
import com.osfans.trime.core.Rime
2020
import com.osfans.trime.data.theme.ColorManager
2121
import com.osfans.trime.data.theme.FontManager
@@ -28,7 +28,7 @@ import splitties.views.dsl.constraintlayout.centerHorizontally
2828
import splitties.views.dsl.constraintlayout.topOfParent
2929

3030
// 显示长度不固定,字体大小正常的内容。用于类型 CANDIDATE, VAR_LENGTH
31-
class CandidateAdapter(private val theme: Theme) : BaseQuickAdapter<CandidateListItem, CandidateAdapter.ViewHolder>() {
31+
class CandidateAdapter(private val theme: Theme) : BaseQuickAdapter<CandidateItem, CandidateAdapter.ViewHolder>() {
3232
enum class CommentPosition {
3333
UNKNOWN,
3434
TOP,
@@ -119,7 +119,7 @@ class CandidateAdapter(private val theme: Theme) : BaseQuickAdapter<CandidateLis
119119
override fun onBindViewHolder(
120120
holder: ViewHolder,
121121
position: Int,
122-
item: CandidateListItem?,
122+
item: CandidateItem?,
123123
) {
124124
item?.run {
125125
holder.candidate.text = text

app/src/main/java/com/osfans/trime/ime/symbol/LiquidKeyboard.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import androidx.recyclerview.widget.RecyclerView
1313
import androidx.recyclerview.widget.StaggeredGridLayoutManager
1414
import com.chad.library.adapter4.util.setOnDebouncedItemClick
1515
import com.google.android.flexbox.FlexboxLayoutManager
16-
import com.osfans.trime.core.CandidateListItem
16+
import com.osfans.trime.core.CandidateItem
1717
import com.osfans.trime.core.Rime
1818
import com.osfans.trime.daemon.RimeSession
1919
import com.osfans.trime.data.SymbolHistory
@@ -169,7 +169,7 @@ class LiquidKeyboard(
169169
val items =
170170
data.map {
171171
val text = if (tag.type == SymbolBoardType.SYMBOL) it.label else it.text
172-
CandidateListItem("", text)
172+
CandidateItem("", text)
173173
}
174174
initVarLengthKeys(items)
175175
}
@@ -216,7 +216,7 @@ class LiquidKeyboard(
216216
}
217217
}
218218

219-
private fun initVarLengthKeys(data: List<CandidateListItem>) {
219+
private fun initVarLengthKeys(data: List<CandidateItem>) {
220220
if (onAdapterChange(varLengthAdapter)) {
221221
// 设置布局管理器
222222
keyboardView.apply {

app/src/main/jni/librime_jni/jni-utils.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ class GlobalRefSingleton {
145145
jclass Rime;
146146
jmethodID HandleRimeNotification;
147147

148-
jclass CandidateListItem;
149-
jmethodID CandidateListItemInit;
148+
jclass CandidateItem;
149+
jmethodID CandidateItemInit;
150150

151151
jclass CandidateProto;
152152
jmethodID CandidateProtoInit;
@@ -212,10 +212,10 @@ class GlobalRefSingleton {
212212
env->GetStaticMethodID(Rime, "handleRimeNotification",
213213
"(Ljava/lang/String;Ljava/lang/String;)V");
214214

215-
CandidateListItem = reinterpret_cast<jclass>(env->NewGlobalRef(
216-
env->FindClass("com/osfans/trime/core/CandidateListItem")));
217-
CandidateListItemInit = env->GetMethodID(
218-
CandidateListItem, "<init>", "(Ljava/lang/String;Ljava/lang/String;)V");
215+
CandidateItem = reinterpret_cast<jclass>(env->NewGlobalRef(
216+
env->FindClass("com/osfans/trime/core/CandidateItem")));
217+
CandidateItemInit = env->GetMethodID(
218+
CandidateItem, "<init>", "(Ljava/lang/String;Ljava/lang/String;)V");
219219

220220
CandidateProto = reinterpret_cast<jclass>(env->NewGlobalRef(
221221
env->FindClass("com/osfans/trime/core/RimeProto$Candidate")));

app/src/main/jni/librime_jni/rime_jni.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -548,11 +548,11 @@ Java_com_osfans_trime_core_Rime_getRimeCandidates(JNIEnv *env, jclass clazz,
548548
auto candidates = Rime::Instance().getCandidates(start_index, limit);
549549
int size = static_cast<int>(candidates.size());
550550
jobjectArray array =
551-
env->NewObjectArray(size, GlobalRef->CandidateListItem, nullptr);
551+
env->NewObjectArray(size, GlobalRef->CandidateItem, nullptr);
552552
for (int i = 0; i < size; i++) {
553553
auto &candidate = candidates[i];
554-
auto item = JRef<>(env, env->NewObject(GlobalRef->CandidateListItem,
555-
GlobalRef->CandidateListItemInit,
554+
auto item = JRef<>(env, env->NewObject(GlobalRef->CandidateItem,
555+
GlobalRef->CandidateItemInit,
556556
*JString(env, candidate.second),
557557
*JString(env, candidate.first)));
558558
env->SetObjectArrayElement(array, i, item);

0 commit comments

Comments
 (0)