GitHub action triggers like pull_request [labeled, unlabeled] should support label filter

[zhouzhuojie]

Context

If we have workflows attached with on.pull_request [labeled, unlabeled] event trigger, it runs no matter what labels are added/removed.

• This may not be the ideal scenario that the workflow may be expensive or taking long time to run, and it would be great if the labeled action can also have a label filter that get triggered.
• And many unnecessary workflows/jobs are showing as "skipped" in the UI, not a great user experience.

Proposal syntax

on:
  pull_request:
    types: [labeled, unlabeled]
    label_filter: '*' # which is the default, and we can use the same file pattern match like 'test', '*test', '*bot'

OR

on:
  pull_request:
    types: [labeled, labeled:*, unlabeled:*, labeled:*test, labeled:*bot]

[seemethere]

+1 This is a key feature for us, it allows us to have workflows triggered on specific labels instead of having to do the current hack like:

  should-run:
    runs-on: ubuntu-latest
    if: >-
      github.event_name != 'pull_request' ||
      contains(github.event.pull_request.labels.*.name, 'ci/future')
    steps:
      - run: echo "noop"

Which results in a bunch of skipped checks being present in our CI statuses:

Reference PR: pytorch/pytorch#61720

[janeyx99]

+1 as well! Without this filtering feature for labels, it is also highly difficult/hacky to enable singular or simply a subset of workflows to run or rerun. Simply allowing workflows to be triggered by the labeled event does not resolve this.

on: pull_request
   types: [opened, reopened, synchronize, labeled]

There is no good way to have different workflows be triggered by different labels in one PR with this method because the labeled event is too generic. Once I add one label A to enable workflow A, every other workflow will be triggered and rerun, even if they were already running for hours and I had not wanted to retrigger them.

[ritesh-singh]

+1 to it. Filtering on workflow level for label / issue_comment even types are needed to avoid the unnecessary skips checks UI on PR and action tab.

[jamesmhaley]

+1 bump.

[swap357]

+1