Line span on PR comment doesn't understand old vs. new line numbers #178435
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Bug
Body
I tried to add a comment on a PR, spanning a few deleted lines and a couple of added lines that replaced them. However, because of a bunch of lines deleted earlier in the file, the deleted line numbers were higher than the added line numbers. This completely confused the comment system, because it was determined that the "end line" had to be greater than the "start line", and it wasn't happy with a comment spanning from "old line 143" to "new line 129" despite having a matching line in between.
Reproduction Steps
Have a PR with several lines deleted near the beginning, and some changes later on.
Try to save a comment starting on a deleted line and ending on an added line (with a lower line number, despite being displayed later).
Additionally, I tried to report this through the only channel GitHub actually provides for support and was told I didn't have access to that (despite clearly having access to that), which seems... misguided.
Beta Was this translation helpful? Give feedback.
All reactions