Handle empty meetings

Author: oliverguenther

modules/meeting/app/components/meetings/header_component.html.erb

@@ -49,7 +49,7 @@
         end
       end
 
-      if OpenProject::FeatureDecisions.meetings_presentation_mode_active?
+      if OpenProject::FeatureDecisions.meetings_presentation_mode_active? && @meeting.agenda_items.any?
         header.with_action_button(
           tag: :a,
           scheme: :secondary,

modules/meeting/app/components/meetings/presentation_component.html.erb

@@ -48,7 +48,6 @@
     <% end %>
   <% end %>
 
-  <!-- Footer with controls -->
   <div class="op-meeting-presentation--footer">
     <div class="op-meeting-presentation--footer-left">
       <%= render(Primer::Beta::Button.new(

modules/meeting/app/components/meetings/presentation_component.rb

@@ -50,6 +50,10 @@ def check_for_updates_interval
       5_000
     end
 
+    def render?
+      @agenda_item_ids.any?
+    end
+
     def current_item
       return nil if @current_item.nil?
 

modules/meeting/app/controllers/meeting_presentation_controller.rb

@@ -35,6 +35,7 @@ class MeetingPresentationController < ApplicationController
   before_action :check_feature_flag
 
   before_action :find_meeting
+  before_action :check_presentable
   before_action :find_agenda_item, only: [:check_for_updates]
 
   load_and_authorize_with_permission_in_optional_project :view_meetings
@@ -79,6 +80,14 @@ def check_feature_flag
     end
   end
 
+  def check_presentable
+    if @meeting.agenda_items.empty?
+      flash[:warning] = t("meeting.presentation_mode.no_items_flash")
+      redirect_to project_meeting_path(@meeting.project, @meeting),
+                  status: :see_other
+    end
+  end
+
   def determine_current_id
     return sorted_agenda_item_ids.first if params[:current_id].blank?
 

modules/meeting/config/locales/en.yml

@@ -382,6 +382,7 @@ en:
       previous: "Previous"
       next: "Next"
       no_items: "No agenda items"
+      no_items_flash: "There are no agenda items to present."
 
   meeting_section:
     untitled_title: "Untitled section"

modules/meeting/spec/features/presentation/meeting_presentation_mode_spec.rb

@@ -38,7 +38,6 @@
   shared_let(:project) { create(:project, enabled_module_names: %w[meetings]) }
   shared_let(:user) do
     create :user,
-           lastname: "Presenter",
            preferences: { time_zone: "Etc/UTC" },
            member_with_permissions: { project => %i[view_meetings manage_agendas manage_outcomes] }
   end
@@ -74,7 +73,10 @@ def outcome_field_for(agenda_item)
     expect(page).to have_text("First Item")
     expect(page).to have_text("Second Item")
 
-    click_link_or_button "Present"
+    within("#meetings-header-component") do
+      expect(page).to have_link("Present")
+      click_link_or_button "Present"
+    end
 
     # Verify we're in presentation mode
     expect(page).to have_current_path(project_meeting_presentation_path(project, meeting), ignore_query: true)
@@ -151,4 +153,28 @@ def outcome_field_for(agenda_item)
     # Verify we're back on the show page
     expect(page).to have_current_path(project_meeting_path(project, meeting), ignore_query: true)
   end
+
+  context "with an empty meeting" do
+    let(:meeting) do
+      create :meeting,
+             project:,
+             title: "Empty meeting",
+             start_time: "2025-10-31T10:00:00Z",
+             state: :in_progress,
+             author: user
+    end
+
+    it "does not show the present button" do
+      show_page.visit!
+
+      within("#meetings-header-component") do
+        expect(page).to have_no_link("Present")
+      end
+
+      # When visiting the presentation mode directly
+      visit project_meeting_presentation_path(project, meeting)
+
+      expect_flash(type: :warning, message: "There are no agenda items to present.")
+    end
+  end
 end