supported forced installs through the REST api

Author: Matthew Peck

test/controllers/v1/bundles_controller_test.exs

@@ -134,6 +134,14 @@ defmodule Cog.V1.BundlesControllerTest do
             "version has already been taken"] = json_response(conn, 409)["errors"]
   end
 
+  test "force enables installation of an already installed version", %{authed: requestor} do
+    config = config(:map)
+    {:ok, _orig_version3} = Bundles.install(%{"name" => config["name"], "version" => config["version"], "config_file" => config})
+
+    conn = api_request(requestor, :post, "/v1/bundles", body: %{"bundle" => %{"config" => config, "force" => true}})
+    assert response(conn, 201)
+  end
+
   test "fails to install with semantically invalid config", %{authed: requestor} do
     # The config includes rules that mention permissions; if we remove
     # those permissions, installation should fail

web/controllers/v1/bundles_controller.ex

@@ -76,9 +76,10 @@ defmodule Cog.V1.BundlesController do
 
   defp install_bundle(params) do
     with {:ok, config}                 <- parse_config(params),
+         {:ok, install_type}           <- install_type(params),
          {:ok, valid_config, warnings} <- validate_config(config),
          {:ok, params}                 <- merge_config(params, valid_config),
-         {:ok, bundle}                 <- Repository.Bundles.install(params) do
+         {:ok, bundle}                 <- Repository.Bundles.install(install_type, params) do
            {:ok, bundle, warnings}
     end
   end
@@ -92,6 +93,11 @@ defmodule Cog.V1.BundlesController do
   defp parse_config(_),
     do: {:error, :no_config}
 
+  defp install_type(%{"force" => true}),
+    do: {:ok, :force}
+  defp install_type(_),
+    do: {:ok, :normal}
+
   # If we have a file, check to see if the filename has the correct extension
   defp validate_file_format(%Plug.Upload{filename: filename}) do
     if Config.config_extension?(filename) do