From 6ecaae8ce8fa364bae2202b4a1af32c5c10ab984 Mon Sep 17 00:00:00 2001
From: Adrian Cole <adrian@tetrate.io>
Date: Sat, 6 Apr 2024 09:09:26 +0800
Subject: [PATCH] fixes bug setting service names to empty

Signed-off-by: Adrian Cole <adrian@tetrate.io>
---
 brave/src/main/java/brave/handler/MutableSpan.java |  6 ++++--
 .../test/java/brave/handler/MutableSpanTest.java   | 14 ++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/brave/src/main/java/brave/handler/MutableSpan.java b/brave/src/main/java/brave/handler/MutableSpan.java
index d48b3dbd60..73d9d3c722 100644
--- a/brave/src/main/java/brave/handler/MutableSpan.java
+++ b/brave/src/main/java/brave/handler/MutableSpan.java
@@ -365,8 +365,9 @@ public void kind(@Nullable Kind kind) {
   public void localServiceName(@Nullable String localServiceName) {
     if (localServiceName == null || localServiceName.isEmpty()) {
       this.localServiceName = null;
+    } else {
+      this.localServiceName = localServiceName;
     }
-    this.localServiceName = localServiceName;
   }
 
   /**
@@ -438,8 +439,9 @@ public void localPort(int localPort) {
   public void remoteServiceName(@Nullable String remoteServiceName) {
     if (remoteServiceName == null || remoteServiceName.isEmpty()) {
       this.remoteServiceName = null;
+    } else {
+      this.remoteServiceName = remoteServiceName;
     }
-    this.remoteServiceName = remoteServiceName;
   }
 
   /**
diff --git a/brave/src/test/java/brave/handler/MutableSpanTest.java b/brave/src/test/java/brave/handler/MutableSpanTest.java
index a3c3965bdd..daf3a64f94 100644
--- a/brave/src/test/java/brave/handler/MutableSpanTest.java
+++ b/brave/src/test/java/brave/handler/MutableSpanTest.java
@@ -285,6 +285,13 @@ class Tag {
     );
   }
 
+  @Test void localServiceNameCoercesEmptyToNull() {
+    MutableSpan span = new MutableSpan();
+    span.localServiceName("FavStar");
+    span.localServiceName("");
+    assertThat(span.localServiceName()).isNull();
+  }
+
   @Test void localServiceNamePreservesCase() {
     String expectedLocalServiceName = "FavStar";
     MutableSpan span = new MutableSpan();
@@ -292,6 +299,13 @@ class Tag {
     assertThat(span.localServiceName()).isEqualTo(expectedLocalServiceName);
   }
 
+  @Test void remoteServiceNameCoercesEmptyToNull() {
+    MutableSpan span = new MutableSpan();
+    span.remoteServiceName("FavStar");
+    span.remoteServiceName("");
+    assertThat(span.remoteServiceName()).isNull();
+  }
+
   @Test void remoteServiceNamePreservesCase() {
     String expectedRemoteServiceName = "FavStar";
     MutableSpan span = new MutableSpan();