diff --git a/brave/src/main/java/brave/handler/MutableSpan.java b/brave/src/main/java/brave/handler/MutableSpan.java index d48b3dbd6..73d9d3c72 100644 --- a/brave/src/main/java/brave/handler/MutableSpan.java +++ b/brave/src/main/java/brave/handler/MutableSpan.java @@ -365,8 +365,9 @@ public void kind(@Nullable Kind kind) { public void localServiceName(@Nullable String localServiceName) { if (localServiceName == null || localServiceName.isEmpty()) { this.localServiceName = null; + } else { + this.localServiceName = localServiceName; } - this.localServiceName = localServiceName; } /** @@ -438,8 +439,9 @@ public void localPort(int localPort) { public void remoteServiceName(@Nullable String remoteServiceName) { if (remoteServiceName == null || remoteServiceName.isEmpty()) { this.remoteServiceName = null; + } else { + this.remoteServiceName = remoteServiceName; } - this.remoteServiceName = remoteServiceName; } /** diff --git a/brave/src/test/java/brave/handler/MutableSpanTest.java b/brave/src/test/java/brave/handler/MutableSpanTest.java index a3c3965bd..daf3a64f9 100644 --- a/brave/src/test/java/brave/handler/MutableSpanTest.java +++ b/brave/src/test/java/brave/handler/MutableSpanTest.java @@ -285,6 +285,13 @@ class Tag { ); } + @Test void localServiceNameCoercesEmptyToNull() { + MutableSpan span = new MutableSpan(); + span.localServiceName("FavStar"); + span.localServiceName(""); + assertThat(span.localServiceName()).isNull(); + } + @Test void localServiceNamePreservesCase() { String expectedLocalServiceName = "FavStar"; MutableSpan span = new MutableSpan(); @@ -292,6 +299,13 @@ class Tag { assertThat(span.localServiceName()).isEqualTo(expectedLocalServiceName); } + @Test void remoteServiceNameCoercesEmptyToNull() { + MutableSpan span = new MutableSpan(); + span.remoteServiceName("FavStar"); + span.remoteServiceName(""); + assertThat(span.remoteServiceName()).isNull(); + } + @Test void remoteServiceNamePreservesCase() { String expectedRemoteServiceName = "FavStar"; MutableSpan span = new MutableSpan();