-
-
Notifications
You must be signed in to change notification settings - Fork 34
Upgrade monitor #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade monitor #1498
Conversation
|
It seems the previous way of building the chart name doesn't work anymore. When I click on it, it says "Chart Not Found". So, what I did was to remove it from the URL. The image in the PR description is what will be shown on page view. Haven't figured out to construct the query param to point to a specific chart and the docs/communities haven't been helpful on it. |
benoit74
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I get where I should have a look in the dashboard to see only stats from the "current node" (scraper). Everywhere I go I only see stats from my host machine, not only the scraper container.
There is also a bad warning (probably because I did not get how to tweak things to have the task manager start my local monitor image instead of the officially published one):
And finally, it looks like I have not been precise enough. It is important to also update the image at https://github.com/kiwix/container-images/tree/main/netdata since this is the one we use to run https://monitoring.openzim.org ; note that it would maybe be easier to host this image Dockerfile inside the zimfarm repo since it is so tight to the Zimfarm ; at least I don't mind if you temporarily host it there for the review to complete, and then we move it again over there.
da9f283 to
d342b5e
Compare
|
I have updated the PR description. Still, it appears there's significant changes in the netdata operates now. I have tried disabling their cloud offering but it seems it doesn't respect my decision. Hence, I have to configure the UI to point me to |
|
Also had to rebase the branch on top of main because of #1521 |
|
I still don't get what I'm seeing in the graphs. I expect to see resource usage (mostly CPU and memory) of the scraper container itself. Here it looks like I see resource usage of my whole machine, not only the scraper. Do I miss something? |
Could you show a picture? |
|
Applied some updates. See updated README. Notable changes since last PRs are:
The system-level collection collects entire metrics for my host machine making it hard to discern worker-related metrics. Should we use this as an opportunity to make all containers started within the manager start with a known prefix and collect only their stats. Collecting stats of the zimfarm backend and postgresdb (because I am in development) is quite unnecessary and reducing the amount of data collected could speed up streaming speed. What do you think? |
|
You will of course need to build the monitor image with the same name set as |
|
I'm now a bit confused. How did it worked in the past? Did we collected metrics from all containers on the worker host, no matter which task they belong to? And also host metrics? |

Rationale
Monitor (used to monitor Zimfarm tasks consumption) is still using Netdata 1.38 (Feb 2023) while we are now at 2.8.0. Also, monitor is currently not in the dev docker graph making it hard to view the statistics for local tasks. This PR aims to address these points.
Changes
monitorservice to dev docker graph with profileworkernetdatasubfolder indevdirectory. This is what would be hosted on https://github.com/kiwix/container-images/blob/main/netdata/netdata.confurllibin regen-stream because netdata base image doesn't have pip installed and we can't install requestsDockerfileor shell scriptsuuid5function to build worker stream key from SHA256 fingerprintgo.dplugin which communicates to the redis instance of the scraper can connect to it via it's nameThis closes #1102