Fix the PG Problem Editor for files that have spaces in the filename. #2062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glob in the `getBackupTimes` method needs special quoting to handle spaces in filenames. To test this try to edit a pg problem with spaces in the filename. On develop the editor won't open, and you get an exception screen. With this pull request it will work of course.
drgrice1
force-pushed
the
bugfix/pg-editor-spaces-in-filenames
branch
from
d6601dd to
4aad489
Compare
Alex-Jordan
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glob in the
getBackupTimesmethod needs special quoting to handle spaces in filenames.To test this try to edit a pg problem with spaces in the filename. On develop the editor won't open, and you get an exception screen. With this pull request it will work of course.