Round initial point value to match step size in SingleProblemGrader. #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
approved these changes
Jun 13, 2023
Member
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
This looks good.
I have just one minor suggestion on code formatting.
somiaj
force-pushed
the
bugfix-point-rounding
branch
from
542991d to
d959e82
Compare
Alex-Jordan
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the point value in the single problem grader, the initial value needs to also be rounded to the nearest stepsize. Without this it is possible that the initial point value is an invalid number for the point value input.