WeBWorK 2.18 #1946
Merged
WeBWorK 2.18 #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If I'd like for somebody else's PR to be targeted to this branch, should I just move the target myself? Or ask that person? |
Member
Author
|
You can move it. |
Contributor
|
At what point do we change the VERSION file to say 2.18? |
Member
Author
|
We just have to merge #1947 for that. We can do that anytime now. I have been holding off as it makes it easier to keep develop and the release candidate branches in sync. I think it is time now though. |
alternate pathway to user detail
Admin menu perm check
This is the result of executing the bin/dev_scripts/update-copyright script. In addition the copyright in some of the javascript files was manually updated as the script didn't catch those.
Update the copyright in file headers and webwork2 VERSION.
Round initial point value to match step size in SingleProblemGrader.
The glob in the `getBackupTimes` method needs special quoting to handle spaces in filenames. To test this try to edit a pg problem with spaces in the filename. On develop the editor won't open, and you get an exception screen. With this pull request it will work of course.
When using the PGProblemEditor with a blank_problem, use the file `blankProblem.pg` located in the courses templates directory, and copy the site configured blankProblem if the file does not exist. This makes it so the blank_problem that isn't in a set act similar to blank problems that are in sets.
… inappropriate warning
…enames Fix the PG Problem Editor for files that have spaces in the filename.
This is a new bug caused by a very old typo. The grep that is now in templates/ContentGenerator/LoginProctor.html.ep should be filtering out the proctor_passwd input, but instead is skipping the non-existent proctor_password input, and adding a hidden input for the proctor_passwd input. The typo traces back to 2007. What happens as a result is that if you incorrectly type the proctor password on the first attempt, then all successive attemps are using the incorrect password in the hidden field instead of the newly entered password in the input shown on the screen. Thus once you have a typo in entering the password, you can not sign in again without leaving the proctor authentication page and coming back. I have not locked down how it somehow worked before, but I tested with webwork 2.17 and you can authenticate with the proctor user after a first incorrect attempt. So this is probably something to do with Mojolicous autofilling input values or the rework of the params method.
Most text is now translatable. The links no longer use the "html" extension. The "html" extension is only needed for actual html files. Mojolicious does not need those. This now uses properly resolved links for routes instead. The problems with the clipboard icon are fixed. That and several other issues were caused by using css classes that are from bootstrap 5.3, that are not in bootstrap 5.2. This requires changes to the way the sample problems are parsed that are in a pull request to the PG side of this.
Fix codemirror folding for html and xml.
Don't strip the password from the input parameters for the rpc endpoints.
These paths have been incorrect since 2015 when they were added. The comment that was there about these is completely incorrect. It states that these should be complete urls. They should not be urls at all. Instead they should be directories. The only place that these are used is in PGalias.pm to search for auxiliary html files or images, and there they are treated as directories. Also remove the completely unused pdfPath setting.
move help link outside of h1
Correct htmlPath and imagesPath settings in defaults.config
stop supporting a typo
This is just my suggestion for #2139 that didn't get applied before it was merged.
This was missed in #2098.
Take care of this before the release so that at release time at least the message about needing to update the browserslist db is not shown.
Add the installation of Perl::Tidy to the docker build.
Tweak page title style.
refactor hardcopy themes
Hardcopy themes editor
Sample Problems link in PGeditor now shows the sample problems locally
Update the browserslist db.
allow enter key to activate submit/check
pick and choose permission levels to receive feedback
Switch the docker compose branch back to main for the final release.
help tooltips for the set details page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate. Pull requests that are desired to be in the release should be target on this branch.