Skip to content

[CPU]Support RoPE for GLM4 #32682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[CPU]Support RoPE for GLM4 #32682

wants to merge 4 commits into from
+112 −52

Conversation

@zhangYiIntel
Copy link
Contributor

@zhangYiIntel zhangYiIntel commented Nov 5, 2025

Details:

  • Support RoPE for GLM4

Tickets:

@zhangYiIntel zhangYiIntel requested review from a team as code owners November 5, 2025 01:30
@zhangYiIntel zhangYiIntel requested review from CuriousPanCake and removed request for a team November 5, 2025 01:30
@github-actions github-actions bot added category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations labels Nov 5, 2025
@zhangYiIntel zhangYiIntel force-pushed the yi3/support_rope_glm4 branch from b442d44 to 0e8211a Compare November 5, 2025 01:45
@yuxu42 yuxu42 requested a review from chenhu-wang November 5, 2025 01:53
@zhangYiIntel zhangYiIntel force-pushed the yi3/support_rope_glm4 branch from 0e8211a to 318f64c Compare November 5, 2025 02:33
@mryzhov mryzhov self-assigned this Nov 5, 2025
@mryzhov mryzhov self-requested a review November 5, 2025 10:51
mryzhov
mryzhov reviewed Nov 6, 2025
View reviewed changes
...ansformations/src/transformations/common_optimizations/fuse_rotary_positional_embeddings.cpp Outdated

auto qkv_proj = pattern::wrap_type<v1::VariadicSplit>({reshape, 3, {"ndims", "ndims"}});
qkv_proj->set_output_size(2);
auto slice_1 = NewGenSlice(reshape, 0, "ndims", 1, 3) | qkv_proj->output(0);
Copy link
Contributor

@mryzhov mryzhov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works with the default inputs only, if output ID is really important for this transformation, please use the output_index_matches() predicate, see https://github.com/openvinotoolkit/openvino/pull/31647/files

Copy link
Contributor Author

@zhangYiIntel zhangYiIntel Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in cc8c9df

chenhu-wang
chenhu-wang reviewed Nov 7, 2025
View reviewed changes
@zhangYiIntel zhangYiIntel requested review from a team as code owners November 10, 2025 02:14
@github-actions github-actions bot added category: IE Tests OpenVINO Test: plugins and common category: GPU OpenVINO GPU plugin labels Nov 10, 2025
@yuxu42
Copy link
Contributor

yuxu42 commented Nov 11, 2025

Hi @maxnick could you please take a review? Thanks!

@yuxu42 yuxu42 requested a review from mryzhov November 11, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenhu-wang chenhu-wang chenhu-wang approved these changes

@CuriousPanCake CuriousPanCake Awaiting requested review from CuriousPanCake CuriousPanCake is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@mryzhov mryzhov Awaiting requested review from mryzhov

Assignees

@mryzhov mryzhov

Labels

category: CPU OpenVINO CPU plugin category: GPU OpenVINO GPU plugin category: IE Tests OpenVINO Test: plugins and common category: transformations OpenVINO Runtime library - Transformations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhangYiIntel @yuxu42 @mryzhov @chenhu-wang