Skip to content

[PyTorch] : implement support for replicated{1,2,3} pad #28271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

[PyTorch] : implement support for replicated{1,2,3} pad #28271

wants to merge 17 commits into from

Conversation

@11happy
Copy link
Contributor

@11happy 11happy commented Jan 4, 2025

Overview:
This pull request fixes #23322.

Testing:

  • Tested the updated code.
    Screenshot from 2025-01-05 00-46-00

CC:

@11happy 11happy requested a review from a team as a code owner January 4, 2025 19:18
@11happy 11happy requested review from PiotrKrzem and mvafin January 4, 2025 19:18
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Jan 4, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Jan 4, 2025
@11happy
Copy link
Contributor Author

11happy commented Jan 6, 2025

humble ping!
thank you

rkazants
rkazants reviewed Jan 7, 2025
View reviewed changes
rkazants
rkazants reviewed Jan 7, 2025
View reviewed changes
rkazants
rkazants reviewed Jan 7, 2025
View reviewed changes
rkazants
rkazants reviewed Jan 7, 2025
View reviewed changes
rkazants
rkazants reviewed Jan 7, 2025
View reviewed changes
@rkazants
Copy link
Collaborator

rkazants commented Jan 7, 2025

build_jenkins

@11happy 11happy requested a review from rkazants January 20, 2025 15:35
@11happy
merge origin master
0824a3e 
Signed-off-by: 11happy <[email protected]>
@rkazants
Copy link
Collaborator

rkazants commented Jan 23, 2025

build_jenkins

@11happy
Copy link
Contributor Author

11happy commented Jan 25, 2025

I have fixed the code style , ran clang-format.
Thank you

@rkazants
Copy link
Collaborator

rkazants commented Jan 25, 2025

build_jenkins

@11happy
Copy link
Contributor Author

11happy commented Feb 2, 2025

humble ping!
fixed the CI failing cause.
thank you

@rkazants
Copy link
Collaborator

rkazants commented Feb 2, 2025

build_jenkins

rkazants
rkazants reviewed Feb 2, 2025
View reviewed changes
@11happy
fix: git artifact
ac6579a 
Signed-off-by: 11happy <[email protected]>
@rkazants
Copy link
Collaborator

rkazants commented Feb 3, 2025

build_jenkins

rkazants
rkazants reviewed Feb 3, 2025
View reviewed changes
tests/layer_tests/pytorch_tests/test_pad.py Outdated
class TestReplicatePad1D(PytorchLayerTest):
def _prepare_input(self, ndim=4, dtype="float32"):
import numpy as np
input_5d_shape = [5,9,1,1,2,4]
Copy link
Collaborator

@rkazants rkazants Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove input_5d_shape and ndim from here and add normal input_shape to @pytest.mark.parametrize.
The same comment for other tests

Copy link
Contributor Author

@11happy 11happy Feb 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done,
please suggest the input_shapes to keep, currently kept random from my end,
thank you

mvafin
mvafin requested changes Feb 6, 2025
View reviewed changes
@11happy
style: fix position
d560edc 
Signed-off-by: 11happy <[email protected]>
mvafin
mvafin reviewed Feb 20, 2025
View reviewed changes
src/frontends/pytorch/src/op/pad.cpp Outdated
return translate_pad_common(context, data, paddings, pad_value, "reflect");
}

OutputVector translate_replicate_pad_nd(const NodeContext & context) {
Copy link
Contributor

@mvafin mvafin Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
OutputVector translate_replicate_pad_nd(const NodeContext & context) {
OutputVector translate_replicate_pad_nd(const NodeContext& context) {

Copy link
Contributor Author

@11happy 11happy Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

mvafin
mvafin reviewed Feb 20, 2025
View reviewed changes
src/frontends/pytorch/src/op_table.cpp Outdated
Comment on lines 955 to 957
{"aten.replicate_pad1d.default", op::translate_replicate_pad_nd},
{"aten.replicate_pad2d.default", op::translate_replicate_pad_nd},
{"aten.replicate_pad3d.default", op::translate_replicate_pad_nd},
Copy link
Contributor

@mvafin mvafin Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests for torch.export fail. I can see that names are wrong, but tests fail on torch side, please check them

Copy link
Contributor Author

@11happy 11happy Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure but If I am trying to open the logs
image

its just loading & loading not showing the logs. How may I acces the failed logs.
Thank you

Copy link
Contributor Author

@11happy 11happy Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have corrected the names. Thank you

Copy link
Contributor Author

@11happy 11happy Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hii @mvafin can you please start the CI once again please so that I can see the issues.

@11happy
Copy link
Contributor Author

11happy commented Mar 15, 2025

Hello :) is there any further input required from my side, I would like this PR to be completed.
Thank you

@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Mar 31, 2025
@11happy
remove integer inputs
1960c64 
Signed-off-by: 11happy <[email protected]>
@11happy
Copy link
Contributor Author

11happy commented Apr 5, 2025

Hello @mvafin I have currently remove the integer inputs to tests which were causing the CI to fail see the log below.

from user code:
2025-03-27T12:55:26.9123336Z    File "/__w/openvino/openvino/install/tests/layer_tests/pytorch_tests/test_pad.py", line 345, in forward
2025-03-27T12:55:26.9123467Z     return torch.ops.aten.replication_pad3d(x,self.pads)
2025-03-27T12:55:26.9123472Z 
2025-03-27T12:55:26.9123632Z Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
2025-03-27T12:55:26.9123696Z . Retrying...
2025-03-27T12:55:26.9123919Z An error occurred: Overloaded torch operator invoked from Python failed to match any schema:
2025-03-27T12:55:26.9124174Z aten::replication_pad3d() Expected a value of type 'List[int]' for argument 'padding' but instead found type 'int'.
2025-03-27T12:55:26.9124243Z Position: 1
2025-03-27T12:55:26.9124305Z Value: 3
2025-03-27T12:55:26.9124484Z Declaration: aten::replication_pad3d(Tensor self, SymInt[6] padding) -> Tensor
2025-03-27T12:55:26.9124627Z  Python error details: TypeError: 'int' object is not iterable
2025-03-27T12:55:26.9124631Z 
2025-03-27T12:55:26.9124886Z aten::replication_pad3d() Expected a value of type 'List[int]' for argument 'padding' but instead found type 'int'.
2025-03-27T12:55:26.9124961Z Position: 1
2025-03-27T12:55:26.9125023Z Value: 3
2025-03-27T12:55:26.9125280Z Declaration: aten::replication_pad3d.out(Tensor self, SymInt[6] padding, *, Tensor(a!) out) -> Tensor(a!)
2025-03-27T12:55:26.9125415Z  Python error details: TypeError: 'int' object is not iterable
2025-03-27T12:55:26.9125419Z 
2025-03-27T12:55:26.9125422Z

@11happy
Copy link
Contributor Author

11happy commented Apr 5, 2025

also to correct this issue I was thinking how do I detect from integer padding what type of padding needs to be done ie 1d ,2d or 3d, also this issue will also be there in reflection_pad as well as it also have similar implementation.
Thank you

@11happy 11happy requested a review from mvafin April 5, 2025 07:51
@11happy
Copy link
Contributor Author

11happy commented Apr 5, 2025

humble ping! @rkazants

@github-actions github-actions bot removed the Stale label Apr 8, 2025
@mlukasze
Copy link
Contributor

mlukasze commented Apr 15, 2025

build_jenkins

@11happy
Copy link
Contributor Author

11happy commented May 4, 2025

Thank you for running the CI, I can now see the issues, I will resolve them & ping here.
Thank you

@11happy
Copy link
Contributor Author

11happy commented May 7, 2025 

Internal Error - We're working hard to fix this as soon as possible!
FAILED install/tests/model_hub_tests/transformation_tests/test_transformations.py::test_transformations_precommit[CPU-fxmarty/really-tiny-falcon-testing-https:/huggingface.co/fxmarty/really-tiny-falcon-testing-None-None-ts_names25-layer_types25] - huggingface_hub.errors.HfHubHTTPError: 500 Server Error: Internal Server Error for url: https://huggingface.co/api/models/fxmarty/really-tiny-falcon-testing/tree/main?recursive=True&expand=False (Request ID: Root=1-67fe2520-2ab2a15d36376aeb3cd0ca2e;06d8c947-6132-479d-bd1b-c5cabb628938)

The CI is failing mostly due to other issues, currently there is no CI failure for this PRs changes.

Thank you

@mlukasze
Copy link
Contributor

mlukasze commented May 21, 2025

build_jenkins

@11happy
Copy link
Contributor Author

11happy commented May 21, 2025 •
edited
Loading

I am not able to open these 3 CI failures,
Thank you
image

@mlukasze
Copy link
Contributor

mlukasze commented May 22, 2025

sure, let me check is it sporadic problem with infra or problem with code/tests

@mlukasze
Copy link
Contributor

mlukasze commented May 22, 2025

turned out it was sporadic on our side
CI is green
@mvafin && @rkazants for your attention, please

@mlukasze mlukasze requested review from mmikolajcz and removed request for PiotrKrzem May 22, 2025 11:47
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 6, 2025
@11happy 11happy closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkazants rkazants Awaiting requested review from rkazants

@mvafin mvafin Awaiting requested review from mvafin

@mmikolajcz mmikolajcz Awaiting requested review from mmikolajcz

Assignees

@mvafin mvafin

@rkazants rkazants

Labels

category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support aten::replication_pad{1,2,3}d for pytorch models

6 participants

@11happy @rkazants @mvafin @mlukasze @sys-openvino-ci @p-wysocki