Skip to content

Commit 024651d

Browse files
Fix linting issues and change errors to warnings in logs
1 parent 8e87a43 commit 024651d

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

src/django/api/partner_fields/base_provider.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def fetch_data(
2929
field_name = self._get_field_name()
3030

3131
if raw_data is None:
32-
logger.error(
32+
logger.warning(
3333
f"No raw data found for '{field_name}' partner field. "
3434
f"Production location '{production_location.id}' ID"
3535
)
@@ -38,7 +38,7 @@ def fetch_data(
3838
contributor_info = self.__get_contributor_info()
3939

4040
if contributor_info is None:
41-
logger.error(
41+
logger.warning(
4242
f"No contributor found for '{field_name}' partner field. "
4343
f"Production location '{production_location.id}' ID"
4444
)
@@ -77,11 +77,10 @@ def __get_contributor_info(self) -> Optional[Dict[str, Any]]:
7777
field_name = self._get_field_name()
7878

7979
try:
80-
partner_field = PartnerField.objects.get_all_including_inactive().get(
81-
name=field_name
82-
)
80+
objects = PartnerField.objects.get_all_including_inactive()
81+
partner_field = objects.get(name=field_name)
8382
except PartnerField.DoesNotExist:
84-
logger.error(
83+
logger.warning(
8584
f"Partner field '{field_name}' not found. "
8685
"System field must exist in database."
8786
)
@@ -94,7 +93,7 @@ def __get_contributor_info(self) -> Optional[Dict[str, Any]]:
9493
)
9594

9695
if not contributor:
97-
logger.error(
96+
logger.warning(
9897
f"No contributor found for '{field_name}' partner field.",
9998
)
10099
return None

src/django/api/serializers/facility/facility_index_details_serializer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ def __serialize_and_sort_partner_fields(
434434
reverse=True
435435
)
436436
except Exception as exc:
437-
logger.error(
437+
logger.warning(
438438
f"Failed to serialize partner field '{field_name}': "
439439
f"{exc}"
440440
)

0 commit comments

Comments
 (0)