Skip to content

Commit e675356

Browse files
authored
chore: remove useless application interface (#2344)
1 parent 3c00b2a commit e675356

3 files changed

Lines changed: 14 additions & 34 deletions

File tree

packages/core-browser/src/bootstrap/app.interface.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import { ConstructorOf } from '@opensumi/di';
2-
import { ApplicationConfig, UrlProvider } from '@opensumi/ide-core-common';
2+
import { UrlProvider } from '@opensumi/ide-core-common';
33

44
import { BrowserModule } from '../browser-module';
55
import { ClientAppContribution } from '../common/common.define';
6+
import { AppConfig } from '../react-providers';
67

78
export type ModuleConstructor = ConstructorOf<BrowserModule>;
89
export type ContributionConstructor = ConstructorOf<ClientAppContribution>;
@@ -22,18 +23,26 @@ export interface IconInfo {
2223
iconMap: IconMap;
2324
}
2425

25-
export interface IClientAppOpts extends Partial<ApplicationConfig> {
26+
export interface IClientAppOpts extends Partial<AppConfig> {
27+
// 模块声明
2628
modules: ModuleConstructor[];
29+
// 贡献点声明
2730
contributions?: ContributionConstructor[];
31+
// 前端模块实例声明
2832
modulesInstances?: BrowserModule[];
33+
// 自定义前后端通信路径
2934
connectionPath?: UrlProvider;
35+
// 支持的通信协议类型
3036
connectionProtocols?: string[];
37+
// 定义用于 OpenSumi 视图插件内的图标集合
3138
iconStyleSheets?: IconInfo[];
32-
useCdnIcon?: boolean;
33-
editorBackgroundImage?: string;
3439
/**
35-
* 插件开发模式下指定的插件路径
40+
* 是否使用 CDN 版本的图标资源
41+
* Electron - 默认为 false
42+
* Web - 默认为 true
3643
*/
44+
useCdnIcon?: boolean;
45+
// 插件开发模式下指定的插件路径
3746
extensionDevelopmentPath?: string | string[];
3847
}
3948

packages/core-common/src/application-props.ts

Lines changed: 0 additions & 28 deletions
This file was deleted.

packages/core-common/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ export * from './command';
99
export * from './menu';
1010
export * from './localize';
1111
export * from './types';
12-
export * from './application-props';
1312
export * from './application-error';
1413
export * from './preferences';
1514
export * from './storage';

0 commit comments

Comments
 (0)