feat: optimized code

bk1012 · bk1012 · commit d65a83417375 · 2024-10-30T10:31:27.000+08:00
diff --git a/packages/quick-open/src/common/icon.ts b/packages/quick-open/src/common/icon.ts
@@ -2,9 +2,7 @@ import { URI } from '@opensumi/ide-core-common';
 
 export function iconPath2URI(iconPath: URI | { light: URI; dark: URI }, themeType?: string): URI | undefined {
   if (URI.isUri(iconPath)) {
-    const tmpIconPath = iconPath as URI;
-
-    return Object.prototype.hasOwnProperty.call(tmpIconPath, 'codeUri') ? tmpIconPath : new URI(tmpIconPath.toString());
+    return 'codeUri' in iconPath ? iconPath : new URI((iconPath as URI).toString());
   }
 
   if ((iconPath.dark || iconPath.light) && themeType) {

Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,7 @@ import { URI } from '@opensumi/ide-core-common';`
`2`	`2`
`3`	`3`	`export function iconPath2URI(iconPath: URI \| { light: URI; dark: URI }, themeType?: string): URI \| undefined {`
`4`	`4`	`if (URI.isUri(iconPath)) {`
`5`		`- const tmpIconPath = iconPath as URI;`
`6`		`-`
`7`		`- return Object.prototype.hasOwnProperty.call(tmpIconPath, 'codeUri') ? tmpIconPath : new URI(tmpIconPath.toString());`
	`5`	`+ return 'codeUri' in iconPath ? iconPath : new URI((iconPath as URI).toString());`
`8`	`6`	`}`
`9`	`7`
`10`	`8`	`if ((iconPath.dark \|\| iconPath.light) && themeType) {`