feat: drop electron 13 support (#3050)

Author: bytemain

packages/core-electron-main/src/bootstrap/services/ui.ts

@@ -82,13 +82,7 @@ export class ElectronMainUIService
   }
 
   async moveToTrash(path: string) {
-    if (semver.lt(process.versions.electron, '13.0.0')) {
-      // Removed: shell.moveItemToTrash()
-      // https://www.electronjs.org/docs/latest/breaking-changes#removed-shellmoveitemtotrash
-      await (shell as any).moveItemToTrash(path);
-    } else {
-      await shell.trashItem(path);
-    }
+    await shell.trashItem(path);
   }
 
   async revealInFinder(path: string) {
@@ -145,23 +139,17 @@ export class ElectronMainUIService
   async showOpenDialog(windowId: number, options: Electron.OpenDialogOptions): Promise<string[] | undefined> {
     return new Promise((resolve, reject) => {
       try {
-        if (semver.lt(process.versions.electron, '6.0.0')) {
-          (dialog as any).showOpenDialog(BrowserWindow.fromId(windowId), options, (paths) => {
-            resolve(paths);
-          });
-        } else {
-          const win = BrowserWindow.fromId(windowId);
-          if (!win) {
-            return reject(new Error(`BrowserWindow ${windowId} not found`));
-          }
-          dialog.showOpenDialog(win, options).then((value) => {
-            if (value.canceled) {
-              resolve(undefined);
-            } else {
-              resolve(value.filePaths);
-            }
-          }, reject);
+        const win = BrowserWindow.fromId(windowId);
+        if (!win) {
+          return reject(new Error(`BrowserWindow ${windowId} not found`));
         }
+        dialog.showOpenDialog(win, options).then((value) => {
+          if (value.canceled) {
+            resolve(undefined);
+          } else {
+            resolve(value.filePaths);
+          }
+        }, reject);
       } catch (e) {
         reject(e);
       }
@@ -170,23 +158,17 @@ export class ElectronMainUIService
   async showSaveDialog(windowId: number, options: Electron.SaveDialogOptions): Promise<string | undefined> {
     return new Promise((resolve, reject) => {
       try {
-        if (semver.lt(process.versions.electron, '6.0.0')) {
-          (dialog as any).showSaveDialog(BrowserWindow.fromId(windowId), options, (path) => {
-            resolve(path);
-          });
-        } else {
-          const win = BrowserWindow.fromId(windowId);
-          if (!win) {
-            return reject(new Error(`BrowserWindow ${windowId} not found`));
-          }
-          dialog.showSaveDialog(win, options).then((value) => {
-            if (value.canceled) {
-              resolve(undefined);
-            } else {
-              resolve(value.filePath);
-            }
-          }, reject);
+        const win = BrowserWindow.fromId(windowId);
+        if (!win) {
+          return reject(new Error(`BrowserWindow ${windowId} not found`));
         }
+        dialog.showSaveDialog(win, options).then((value) => {
+          if (value.canceled) {
+            resolve(undefined);
+          } else {
+            resolve(value.filePath);
+          }
+        }, reject);
       } catch (e) {
         reject(e);
       }

packages/core-electron-main/src/bootstrap/window.ts

@@ -10,7 +10,6 @@ import {
   IpcMainEvent,
   WebPreferences,
 } from 'electron';
-import semver from 'semver';
 import treeKill from 'tree-kill';
 
 import { Injectable, Autowired } from '@opensumi/di';
@@ -216,26 +215,12 @@ export class CodeWindow extends Disposable implements ICodeWindow {
   }
 
   bindEvents() {
-    // 外部打开http
-    if (semver.lt(process.versions.electron, '13.0.0')) {
-      // Deprecated: WebContents new-window event
-      // https://www.electronjs.org/docs/latest/breaking-changes#deprecated-webcontents-new-window-event
-      this.browser.webContents.on('new-window', (event, url) => {
-        if (!event.defaultPrevented) {
-          event.preventDefault();
-          if (url.indexOf('http') === 0) {
-            shell.openExternal(url);
-          }
-        }
-      });
-    } else {
-      this.browser.webContents.setWindowOpenHandler((details) => {
-        if (details.url.indexOf('http') === 0) {
-          shell.openExternal(details.url);
-        }
-        return { action: 'deny' };
-      });
-    }
+    this.browser.webContents.setWindowOpenHandler((details) => {
+      if (details.url.indexOf('http') === 0) {
+        shell.openExternal(details.url);
+      }
+      return { action: 'deny' };
+    });
   }
 
   async clear() {

packages/startup/package.json

@@ -113,7 +113,7 @@
     "@opensumi/ide-dev-tool": "workspace:*",
     "browserfs": "^1.4.3",
     "css-loader": "^2.1.1",
-    "electron": "^18.3.0",
+    "electron": "^22.3.21",
     "file-loader": "^3.0.1",
     "less-loader": "^6.0.0",
     "nodemon": "^2.0.15",

tools/electron/package.json

@@ -48,7 +48,7 @@
     "clean-webpack-plugin": "^3.0.0",
     "copy-webpack-plugin": "^5.0.3",
     "css-loader": "^2.1.1",
-    "electron": "^18.3.0",
+    "electron": "^22.3.21",
     "electron-builder": "^23.0.3",
     "file-loader": "^3.0.1",
     "friendly-errors-webpack-plugin": "^1.7.0",