Skip to content

Commit af9889f

Browse files
committed
feat: improve code
1 parent 6278f4d commit af9889f

2 files changed

Lines changed: 9 additions & 37 deletions

File tree

packages/ai-native/src/browser/ai-core.contribution.ts

Lines changed: 7 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -233,42 +233,13 @@ export class AINativeBrowserContribution
233233

234234
private registerFeature() {
235235
this.contributions.getContributions().forEach((contribution) => {
236-
const contributions = [
237-
{
238-
key: contribution.registerInlineChatFeature?.bind(contribution),
239-
registry: this.inlineChatFeatureRegistry,
240-
},
241-
{
242-
key: contribution.registerChatFeature?.bind(contribution),
243-
registry: this.chatFeatureRegistry,
244-
},
245-
{
246-
key: contribution.registerResolveConflictFeature?.bind(contribution),
247-
registry: this.resolveConflictRegistry,
248-
},
249-
{
250-
key: contribution.registerRenameProvider?.bind(contribution),
251-
registry: this.renameCandidatesProviderRegistry,
252-
},
253-
{
254-
key: contribution.registerChatRender?.bind(contribution),
255-
registry: this.chatRenderRegistry,
256-
},
257-
{
258-
key: contribution.registerTerminalProvider?.bind(contribution),
259-
registry: this.terminalProviderRegistry,
260-
},
261-
{
262-
key: contribution.registerIntelligentCompletionFeature?.bind(contribution),
263-
registry: this.intelligentCompletionsRegistry,
264-
},
265-
];
266-
267-
for (const contrib of contributions) {
268-
if (contrib.key) {
269-
contrib.key(contrib.registry as any);
270-
}
271-
}
236+
contribution.registerInlineChatFeature?.(this.inlineChatFeatureRegistry);
237+
contribution.registerChatFeature?.(this.chatFeatureRegistry);
238+
contribution.registerResolveConflictFeature?.(this.resolveConflictRegistry);
239+
contribution.registerRenameProvider?.(this.renameCandidatesProviderRegistry);
240+
contribution.registerChatRender?.(this.chatRenderRegistry);
241+
contribution.registerTerminalProvider?.(this.terminalProviderRegistry);
242+
contribution.registerIntelligentCompletionFeature?.(this.intelligentCompletionsRegistry);
272243
});
273244
}
274245

packages/ai-native/src/browser/contrib/inline-completions/inline-completions.handler.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,9 @@ export class InlineCompletionHandler extends IAIMonacoContribHandler {
153153
this.aiInlineCompletionsProvider.provideInlineCompletionItems(model, position, context, token),
154154
);
155155

156-
if (completionsResult.items.some((i) => isMultiLineCompletion(i))) {
156+
if (completionsResult && completionsResult.items.some((i) => isMultiLineCompletion(i))) {
157157
this.intelligentCompletionsHandler.applyInlineDecorations(completionsResult);
158+
// 此时用 multi line 的 decoration 来渲染,而 inline completion 则不显示
158159
return { items: [] };
159160
}
160161

0 commit comments

Comments
 (0)