Skip to content

Commit 7a8151b

Browse files
committed
chore: improve code
1 parent a1030d0 commit 7a8151b

1 file changed

Lines changed: 10 additions & 17 deletions

File tree

packages/debug/src/browser/view/breakpoints/debug-breakpoints.view.tsx

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -158,29 +158,22 @@ export const BreakpointFileItem = ({ label, icon, breakpointItems }: BreakpointF
158158
const defaultEnabled = useMemo(() => breakpointItems.some((item) => item.enabled), [breakpointItems]);
159159
const [enabled, setEnabled] = React.useState<boolean>(defaultEnabled);
160160

161-
useEffect(() => {
162-
if (enabled) {
163-
// 找出非 enable 的 breakpoint
164-
const disabledBreakpoints = breakpointItems.filter((item) => !item.enabled);
165-
disabledBreakpoints.forEach((breakpoint) => {
166-
debugBreakpointsService.toggleBreakpointEnable(breakpoint);
167-
});
168-
} else {
169-
const disabledBreakpoints = breakpointItems.filter((item) => item.enabled);
170-
disabledBreakpoints.forEach((breakpoint) => {
171-
debugBreakpointsService.toggleBreakpointEnable(breakpoint);
172-
});
173-
}
174-
}, [enabled]);
175-
176-
const handleCheckBoxChange = () => {
161+
const handleCheckBoxChange = (preEnabled: boolean) => {
162+
const matchBreakpoints = breakpointItems.filter((item) => item.enabled === preEnabled);
163+
matchBreakpoints.forEach((breakpoint) => {
164+
debugBreakpointsService.toggleBreakpointEnable(breakpoint);
165+
});
177166
setEnabled(!enabled);
178167
};
179168

180169
return (
181170
<div className={styles.debug_breakpoints_file_item}>
182171
<div className={styles.file_item_control}>
183-
<CheckBox className={styles.file_item_checkbox} onChange={handleCheckBoxChange} checked={enabled}></CheckBox>
172+
<CheckBox
173+
className={styles.file_item_checkbox}
174+
onChange={() => handleCheckBoxChange(enabled)}
175+
checked={enabled}
176+
></CheckBox>
184177
<i className={cls(icon, styles.file_item_icon)}></i>
185178
</div>
186179
<span>{label}</span>

0 commit comments

Comments
 (0)