networking, virt: generalize conflict detection

This way we can ensure the MAC conflict and IP conflicts are caught, and
in a generic way. With it, we can safely expect to find:
- IP conflicts when there are duplicate IPs in the network
- MAC conflicts when there are duplicate MACs in the network

Co-authored-by: Ram Lavi <[email protected]>
Signed-off-by: Miguel Duarte Barroso <[email protected]>

Author: maiqueb

test/extended/networking/livemigration.go

@@ -30,7 +30,10 @@ import (
 	"github.com/openshift/origin/test/extended/util/image"
 )
 
-const kvIPRequestsAnnot = "network.kubevirt.io/addresses"
+const (
+	kvIPRequestsAnnot     = "network.kubevirt.io/addresses"
+	primaryUDNNetworkName = "overlay"
+)
 
 var _ = Describe("[sig-network][OCPFeatureGate:PersistentIPsForVirtualization][Feature:Layer2LiveMigration] Kubevirt Virtual Machines", func() {
 	// disable automatic namespace creation, we need to add the required UDN label
@@ -570,14 +573,36 @@ func duplicateVM(cli *kubevirt.Client, vmNamespace, vmName string) {
 	Expect(json.Unmarshal([]byte(originalVMIRawAnnotations), &originalVMIAnnotations)).To(Succeed())
 
 	var vmiCreationOptions []kubevirt.Option
+	var vmiExpectations []func()
 	if requestedIPs, hasIPRequests := originalVMIAnnotations[kvIPRequestsAnnot]; hasIPRequests {
 		vmiCreationOptions = append(
 			vmiCreationOptions,
 			kubevirt.WithAnnotations(ipRequests(requestedIPs)),
 		)
+		vmiExpectations = append(vmiExpectations, func() {
+			waitForVMPodEventWithMessage(
+				cli,
+				vmNamespace,
+				duplicateVMName,
+				"IP is already allocated",
+				2*time.Minute,
+			)
+		})
+	} else if hasMACAddressRequest(cli, vmName) {
+		vmiExpectations = append(vmiExpectations, func() {
+			waitForVMPodEventWithMessage(
+				cli,
+				vmNamespace,
+				duplicateVMName,
+				"MAC address conflict detected:",
+				2*time.Minute,
+			)
+		})
 	}
 	Expect(cli.CreateVMIFromSpec(vmNamespace, duplicateVMName, vmiSpec, vmiCreationOptions...)).To(Succeed())
-	waitForVMPodEventWithMessage(cli, vmNamespace, duplicateVMName, "IP is already allocated", 2*time.Minute)
+	for _, expectation := range vmiExpectations {
+		expectation()
+	}
 }
 
 func waitForVMPodEventWithMessage(vmClient *kubevirt.Client, vmNamespace, vmName, expectedEventMessage string, timeout time.Duration) {
@@ -788,7 +813,6 @@ func networkName(netSpecConfig string) string {
 
 // formatAddressesAnnotation converts slice of IPs to the required JSON format for kubevirt addresses annotation
 func formatAddressesAnnotation(preconfiguredIPs []string) (string, error) {
-	const primaryUDNNetworkName = "overlay"
 	if len(preconfiguredIPs) == 0 {
 		return "", nil
 	}
@@ -811,3 +835,12 @@ func formatAddressesAnnotation(preconfiguredIPs []string) (string, error) {
 func ipRequests(ips string) map[string]string {
 	return map[string]string{kvIPRequestsAnnot: ips}
 }
+
+func hasMACAddressRequest(cli *kubevirt.Client, vmName string) bool {
+	macAddress, err := cli.GetJSONPath("vmi", vmName, fmt.Sprintf("{.spec.domain.devices.interfaces[?(@.name=='%s')].macAddress}", primaryUDNNetworkName))
+	if err != nil {
+		return false
+	}
+
+	return strings.TrimSpace(macAddress) != ""
+}