Skip to content

Conversation

@bfournie
Copy link
Contributor

@bfournie bfournie commented May 15, 2024

Remove the configuration of the GCP Internal Load Balancer from the installer as its now being done in the CAPG provider. This allows only the Internal LB to be created to support Private Clusters.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 15, 2024

@bfournie: This pull request references CORS-3296 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Remove the configuration of the GCP Internal Load Balancer from the installer as its now being done in the CAPG provider. This allows only the Internal LB to be created to support Private Clusters.

This depends on kubernetes-sigs/cluster-api-provider-gcp#1222 which is still under review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@bfournie
Copy link
Contributor Author

/cc @patrickdillon @barbacbd

@bfournie
Copy link
Contributor Author

/label platform/google

@openshift-ci openshift-ci bot requested review from barbacbd and patrickdillon May 15, 2024 22:56
@openshift-ci openshift-ci bot requested a review from sadasu May 15, 2024 22:58
Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@bfournie bfournie force-pushed the capg-internal-lb branch from 4e8dea9 to cc8b5fe Compare July 5, 2024 17:41
@bfournie
Copy link
Contributor Author

bfournie commented Jul 6, 2024

/retest

Remove the configuration of the GCP Internal Load Balancer from the
installer as its now being done in the CAPG provider. This allows
only the Internal LB to be created to support Private Clusters.

This depends on kubernetes-sigs/cluster-api-provider-gcp#1222
which is still under review.
@bfournie bfournie force-pushed the capg-internal-lb branch from cc8b5fe to 1422bf7 Compare July 6, 2024 18:11
@bfournie
Copy link
Contributor Author

bfournie commented Jul 6, 2024

/unhold

@bfournie
Copy link
Contributor Author

bfournie commented Jul 6, 2024

CAPG fix to use internal Load Balancer is now being included, so removing hold

@bfournie
Copy link
Contributor Author

bfournie commented Jul 6, 2024

/test altinfra-e2e-gcp-capi-ovn altinfra-e2e-gcp-xpn-capi

@bfournie bfournie changed the title WIP CORS-3296: CAPG - configure Internal LoadBalancer in the provider CORS-3296: CAPG - configure Internal LoadBalancer in the provider Jul 6, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2024
@bfournie
Copy link
Contributor Author

bfournie commented Jul 6, 2024

/unhold

@bfournie
Copy link
Contributor Author

bfournie commented Jul 7, 2024

/test altinfra-e2e-gcp-xpn-capi
/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 4e8dea9b7e4e490fecda4777ea67f6695bdb62e2 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-images 4e8dea9b7e4e490fecda4777ea67f6695bdb62e2 link true /test okd-images
ci/prow/altinfra-periodics-images 4e8dea9b7e4e490fecda4777ea67f6695bdb62e2 link true /test altinfra-periodics-images
ci/prow/e2e-vsphere-ovn-upi 4e8dea9b7e4e490fecda4777ea67f6695bdb62e2 link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie
Copy link
Contributor Author

bfournie commented Jul 7, 2024

/test e2e-gcp-ovn-byo-vpc

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2024

@bfournie: This pull request references CORS-3296 which is a valid jira issue.

In response to this:

Remove the configuration of the GCP Internal Load Balancer from the installer as its now being done in the CAPG provider. This allows only the Internal LB to be created to support Private Clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 579f404 into openshift:master Jul 8, 2024
@bfournie bfournie deleted the capg-internal-lb branch July 8, 2024 15:46
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202407082010.p0.g579f404.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants