Skip to content

CNTRPLANE-1978: add e2e tests for ControlPlaneToDataPlaneConnectivityHealthy condition #7291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

CNTRPLANE-1978: add e2e tests for ControlPlaneToDataPlaneConnectivityHealthy condition #7291

wants to merge 5 commits into from
+360 −17

Conversation

@sdminonne
Copy link
Contributor

@sdminonne sdminonne commented Nov 26, 2025

What this PR does / why we need it:

It adds ControlPlaneToDataPlaneConnectivityHealthy condition values in expectedConditions for e2e

Which issue(s) this PR fixes:

Fixes CNTRPLANE-1978

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@sdminonne: No Jira issue with key CNTRPLANE-1978 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

What this PR does / why we need it:

It adds ControlPlaneToDataPlaneConnectivityHealthy condition values in expectedConditions for e2e

Which issue(s) this PR fixes:

Fixes CNTRPLANE-1978

Special notes for your reviewer:

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Nov 26, 2025
@sdminonne
Copy link
Contributor Author

sdminonne commented Nov 26, 2025

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdminonne
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdminonne
Copy link
Contributor Author

sdminonne commented Nov 26, 2025

/test e2e-aws

@sdminonne
feat(api): Add connectivity conditions to HostedControlPlane CR
60e2d92 
Add DataPlaneToControlPlaneConnectivity and ControlPlaneToDataPlaneConnectivity
condition types to the HostedControlPlane API to signal network connectivity
state between control plane and data plane.

This change creates a dedicated hostedcontrolplane_conditions.go file to match
the organizational pattern used by HostedCluster, and moves existing condition
constants to this new file for consistency.

These conditions follow the True=healthy, False=unhealthy pattern and provide
visibility into connectivity issues that may require external intervention.

The actual controller logic to populate these conditions will be implemented
in future work.

Fixes CNTRLPLANE-1942

Signed-off-by: Salvatore Dario Minonne <[email protected]>
Commit-Message-Assisted-by: Claude (via Claude Code)
@sdminonne
chore(generated): Regenerate API documentation and vendor
4696d62 
Regenerate API documentation and vendor files after adding connectivity
conditions to HostedControlPlane CR. This ensures the generated docs and
vendored code reflect the new condition types.

Signed-off-by: Salvatore Dario Minonne <[email protected]>
Commit-Message-Assisted-by: Claude (via Claude Code)
@sdminonne
fix(CNTRPLANE-1956): adds control plane to data plane condition, vendor
7aee553 
Signed-off-by: Salvatore Dario Minonne <[email protected]>
@sdminonne
fix(CNTRPLANE-1956): adds control plane to data plane condition, reco…
0ae008e 
…nciliation logic

It creates and updates a status.condition in hosted-control-plane CR to show the status of connection between control-plane and data-plane.
It retrieve healthy Nodes. In case No nodes are available the condition is set to Unknown.
It uses uncached client to get konnectivity-agent PODs, one per node normally.
Using clientset to get Logs from konnectivity-agent pods
It adds exposes GetPodLogs func in reconciler to be mocked in unit tests a
As soon at least one konnectivity-agent report logs the connection between ControlPlane and DataPlane works. It sets condition in HCP
The hosted-control-plane condition is copied in hosted-cluster CR

Signed-off-by: Salvatore Dario Minonne <[email protected]>
@sdminonne
feat(api): Add e2e tests for DataPlaneToControlPlaneConnectivity cond…
40909ec 
…ition

It expects DataPlaneToControlPlaneConnectivity=True but when no worker nodes available

Fixes CNTRLPLANE-1978

Signed-off-by: Salvatore Dario Minonne <[email protected]>
Commit-Message-Assisted-by: Claude (via Claude Code)
@sdminonne
Copy link
Contributor Author

sdminonne commented Nov 27, 2025

/test e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@sdminonne: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 40909ec link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sdminonne @openshift-ci-robot