OpenRewrite recipe best practices (#746)

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.recipes.rewrite.OpenRewriteRecipeBestPractices?organizationId=QUxML09wZW4gU291cmNlL09wZW5SZXdyaXRl

Co-authored-by: Moderne <[email protected]>

Author: timtebeek

src/main/resources/META-INF/rewrite/examples.yml

@@ -361,44 +361,44 @@ examples:
 - description: ''
   sources:
   - before: |
-      import java.io.FileReader;
-      import java.io.IOException;
-
       class A {
-          void foo() throws IOException {
+          void foo() throws IllegalAccessException {
               try {
-                  new FileReader("").read();
-              } catch (IOException e) {
-                  throw e;
+                  throw new IllegalAccessException();
+              } catch (Exception e) {
+                  throw e; // `e` is removed below
               }
           }
       }
     after: |
-      import java.io.FileReader;
-      import java.io.IOException;
-
       class A {
-          void foo() throws IOException {
-              new FileReader("").read();
+          void foo() throws IllegalAccessException {
+              throw new IllegalAccessException();
           }
       }
     language: java
 - description: ''
   sources:
   - before: |
+      import java.io.FileReader;
+      import java.io.IOException;
+
       class A {
-          void foo() throws IllegalAccessException {
+          void foo() throws IOException {
               try {
-                  throw new IllegalAccessException();
-              } catch (Exception e) {
-                  throw e; // `e` is removed below
+                  new FileReader("").read();
+              } catch (IOException e) {
+                  throw e;
               }
           }
       }
     after: |
+      import java.io.FileReader;
+      import java.io.IOException;
+
       class A {
-          void foo() throws IllegalAccessException {
-              throw new IllegalAccessException();
+          void foo() throws IOException {
+              new FileReader("").read();
           }
       }
     language: java
@@ -3095,6 +3095,18 @@ examples:
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.SimplifyBooleanExpression
 examples:
+- description: ''
+  sources:
+  - before: |
+      fun getSymbol() : String? {
+          return null
+      }
+    language: kotlin
+  - before: |
+      val isPositive = getSymbol().equals("+") == true
+    after: |
+      val isPositive = getSymbol().equals("+")
+    language: kotlin
 - description: ''
   sources:
   - before: |
@@ -3114,18 +3126,6 @@ examples:
           }
       }
     language: java
-- description: ''
-  sources:
-  - before: |
-      fun getSymbol() : String? {
-          return null
-      }
-    language: kotlin
-  - before: |
-      val isPositive = getSymbol().equals("+") == true
-    after: |
-      val isPositive = getSymbol().equals("+")
-    language: kotlin
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.SimplifyBooleanExpressionWithDeMorgan