TypecastParenPad should not make incorrect changes for Groovy

Fixes #561

Author: timtebeek

src/main/java/org/openrewrite/staticanalysis/TypecastParenPad.java

@@ -25,6 +25,7 @@
 import org.openrewrite.java.style.TypecastParenPadStyle;
 import org.openrewrite.java.tree.J;
 import org.openrewrite.java.tree.JavaSourceFile;
+import org.openrewrite.staticanalysis.groovy.GroovyFileChecker;
 
 import java.util.Optional;
 
@@ -39,37 +40,38 @@ public String getDisplayName() {
     @Override
     public String getDescription() {
         return "Fixes whitespace padding between a typecast type identifier and the enclosing left and right parentheses. " +
-               "For example, when configured to remove spacing, `( int ) 0L;` becomes `(int) 0L;`.";
+                "For example, when configured to remove spacing, `( int ) 0L;` becomes `(int) 0L;`.";
     }
 
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
-        return new TypecastParenPadVisitor();
-    }
-
-    private static class TypecastParenPadVisitor extends JavaIsoVisitor<ExecutionContext> {
-        SpacesStyle spacesStyle;
-        TypecastParenPadStyle typecastParenPadStyle;
+        return Preconditions.check(
+                Preconditions.not(new GroovyFileChecker<>()),
+                new JavaIsoVisitor<ExecutionContext>() {
+                    SpacesStyle spacesStyle;
+                    TypecastParenPadStyle typecastParenPadStyle;
 
-        @Override
-        public J visit(@Nullable Tree tree, ExecutionContext ctx) {
-            if (tree instanceof JavaSourceFile) {
-                SourceFile cu = (SourceFile) requireNonNull(tree);
-                spacesStyle = Optional.ofNullable(cu.getStyle(SpacesStyle.class)).orElse(IntelliJ.spaces());
-                typecastParenPadStyle = Optional.ofNullable(cu.getStyle(TypecastParenPadStyle.class)).orElse(Checkstyle.typecastParenPadStyle());
+                    @Override
+                    public J visit(@Nullable Tree tree, ExecutionContext ctx) {
+                        if (tree instanceof JavaSourceFile) {
+                            SourceFile cu = (SourceFile) requireNonNull(tree);
+                            spacesStyle = Optional.ofNullable(cu.getStyle(SpacesStyle.class)).orElse(IntelliJ.spaces());
+                            typecastParenPadStyle = Optional.ofNullable(cu.getStyle(TypecastParenPadStyle.class)).orElse(Checkstyle.typecastParenPadStyle());
 
-                spacesStyle = spacesStyle.withWithin(spacesStyle.getWithin().withTypeCastParentheses(typecastParenPadStyle.getSpace()));
-            }
-            return super.visit(tree, ctx);
-        }
+                            spacesStyle = spacesStyle.withWithin(spacesStyle.getWithin().withTypeCastParentheses(typecastParenPadStyle.getSpace()));
+                        }
+                        return super.visit(tree, ctx);
+                    }
 
-        @Override
-        public J.TypeCast visitTypeCast(J.TypeCast typeCast, ExecutionContext ctx) {
-            J.TypeCast tc = super.visitTypeCast(typeCast, ctx);
-            tc = (J.TypeCast) new SpacesVisitor<>(spacesStyle, null, null, tc)
-                    .visitNonNull(tc, ctx, getCursor().getParentTreeCursor().fork());
-            return tc;
-        }
+                    @Override
+                    public J.TypeCast visitTypeCast(J.TypeCast typeCast, ExecutionContext ctx) {
+                        J.TypeCast tc = super.visitTypeCast(typeCast, ctx);
+                        tc = (J.TypeCast) new SpacesVisitor<>(spacesStyle, null, null, tc)
+                                .visitNonNull(tc, ctx, getCursor().getParentTreeCursor().fork());
+                        return tc;
+                    }
+                }
+        );
     }
 
 }

src/main/resources/META-INF/rewrite/examples.yml

@@ -360,44 +360,44 @@ examples:
 - description: ''
   sources:
   - before: |
+      import java.io.FileReader;
+      import java.io.IOException;
+
       class A {
-          void foo() throws IllegalAccessException {
+          void foo() throws IOException {
               try {
-                  throw new IllegalAccessException();
-              } catch (Exception e) {
-                  throw e; // `e` is removed below
+                  new FileReader("").read();
+              } catch (IOException e) {
+                  throw e;
               }
           }
       }
     after: |
+      import java.io.FileReader;
+      import java.io.IOException;
+
       class A {
-          void foo() throws IllegalAccessException {
-              throw new IllegalAccessException();
+          void foo() throws IOException {
+              new FileReader("").read();
           }
       }
     language: java
 - description: ''
   sources:
   - before: |
-      import java.io.FileReader;
-      import java.io.IOException;
-
       class A {
-          void foo() throws IOException {
+          void foo() throws IllegalAccessException {
               try {
-                  new FileReader("").read();
-              } catch (IOException e) {
-                  throw e;
+                  throw new IllegalAccessException();
+              } catch (Exception e) {
+                  throw e; // `e` is removed below
               }
           }
       }
     after: |
-      import java.io.FileReader;
-      import java.io.IOException;
-
       class A {
-          void foo() throws IOException {
-              new FileReader("").read();
+          void foo() throws IllegalAccessException {
+              throw new IllegalAccessException();
           }
       }
     language: java
@@ -2834,18 +2834,6 @@ examples:
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.SimplifyBooleanExpression
 examples:
-- description: ''
-  sources:
-  - before: |
-      fun getSymbol() : String? {
-          return null
-      }
-    language: kotlin
-  - before: |
-      val isPositive = getSymbol().equals("+") == true
-    after: |
-      val isPositive = getSymbol().equals("+")
-    language: kotlin
 - description: ''
   sources:
   - before: |
@@ -2865,6 +2853,18 @@ examples:
           }
       }
     language: java
+- description: ''
+  sources:
+  - before: |
+      fun getSymbol() : String? {
+          return null
+      }
+    language: kotlin
+  - before: |
+      val isPositive = getSymbol().equals("+") == true
+    after: |
+      val isPositive = getSymbol().equals("+")
+    language: kotlin
 ---
 type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.SimplifyBooleanReturn
@@ -3187,6 +3187,31 @@ examples:
     language: java
 ---
 type: specs.openrewrite.org/v1beta/example
+recipeName: org.openrewrite.staticanalysis.TypecastParenPad
+examples:
+- description: ''
+  sources:
+  - before: |
+      class A {
+          void m() {
+              int i = ( int ) 0L;
+              int j = (int) 0L;
+              int k = (int)0L;
+              int l = ( int )0L;
+          }
+      }
+    after: |
+      class A {
+          void m() {
+              int i = (int) 0L;
+              int j = (int) 0L;
+              int k = (int) 0L;
+              int l = (int) 0L;
+          }
+      }
+    language: java
+---
+type: specs.openrewrite.org/v1beta/example
 recipeName: org.openrewrite.staticanalysis.URLEqualsHashCodeRecipes
 examples:
 - description: ''

src/test/java/org/openrewrite/staticanalysis/TypecastParenPadTest.java

@@ -0,0 +1,80 @@
+/*
+ * Copyright 2025 the original author or authors.
+ * <p>
+ * Licensed under the Moderne Source Available License (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * https://docs.moderne.io/licensing/moderne-source-available-license
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.openrewrite.staticanalysis;
+
+import org.junit.jupiter.api.Test;
+import org.openrewrite.DocumentExample;
+import org.openrewrite.Issue;
+import org.openrewrite.test.RecipeSpec;
+import org.openrewrite.test.RewriteTest;
+
+import static org.openrewrite.groovy.Assertions.groovy;
+import static org.openrewrite.java.Assertions.java;
+
+class TypecastParenPadTest implements RewriteTest {
+
+    @Override
+    public void defaults(RecipeSpec spec) {
+        spec.recipe(new TypecastParenPad());
+    }
+
+    @DocumentExample
+    @Test
+    void typecastParenPad() {
+        rewriteRun(
+          //language=java
+          java(
+            """
+              class A {
+                  void m() {
+                      int i = ( int ) 0L;
+                      int j = (int) 0L;
+                      int k = (int)0L;
+                      int l = ( int )0L;
+                  }
+              }
+              """,
+            """
+              class A {
+                  void m() {
+                      int i = (int) 0L;
+                      int j = (int) 0L;
+                      int k = (int) 0L;
+                      int l = (int) 0L;
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Issue("https://github.com/openrewrite/rewrite-static-analysis/issues/561")
+    @Test
+    void noChangeForGroovy() {
+        rewriteRun(
+          //language=groovy
+          groovy(
+            """
+              class A {
+                  void m(Object o) {
+                      int l = ( o as String).length()
+                  }
+              }
+              """
+          )
+        );
+    }
+}