Skip to content

Commit c8d2e4f

Browse files
authored
fix: Do not migrate Jackson dependencies not available in v3 (#50)
List explicitly the dependencies with group 'com.fasterxml.jackson.module' that are included in Jackson 3. Fixes gh-49 Signed-off-by: Thomas Vitale <[email protected]>
1 parent d867415 commit c8d2e4f

File tree

2 files changed

+112
-1
lines changed

2 files changed

+112
-1
lines changed

src/main/resources/META-INF/rewrite/jackson-2-3.yml

Lines changed: 86 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,93 @@ recipeList:
7676
newVersion: 3.0.x
7777
- org.openrewrite.java.dependencies.ChangeDependency:
7878
oldGroupId: com.fasterxml.jackson.module
79-
oldArtifactId: "*"
79+
oldArtifactId: jackson-module-scala_2.13
80+
newGroupId: tools.jackson.module
81+
newArtifactId: jackson-module-scala_2.13
82+
newVersion: 3.0.x
83+
- org.openrewrite.java.dependencies.ChangeDependency:
84+
oldGroupId: com.fasterxml.jackson.module
85+
oldArtifactId: jackson-module-scala_2.12
86+
newGroupId: tools.jackson.module
87+
newArtifactId: jackson-module-scala_2.12
88+
newVersion: 3.0.x
89+
- org.openrewrite.java.dependencies.ChangeDependency:
90+
oldGroupId: com.fasterxml.jackson.module
91+
oldArtifactId: jackson-module-scala_3
92+
newGroupId: tools.jackson.module
93+
newArtifactId: jackson-module-scala_3
94+
newVersion: 3.0.x
95+
- org.openrewrite.java.dependencies.ChangeDependency:
96+
oldGroupId: com.fasterxml.jackson.module
97+
oldArtifactId: jackson-module-kotlin
98+
newGroupId: tools.jackson.module
99+
newArtifactId: jackson-module-kotlin
100+
newVersion: 3.0.x
101+
- org.openrewrite.java.dependencies.ChangeDependency:
102+
oldGroupId: com.fasterxml.jackson.module
103+
oldArtifactId: jackson-module-no-ctor-deser
104+
newGroupId: tools.jackson.module
105+
newArtifactId: jackson-module-no-ctor-deser
106+
newVersion: 3.0.x
107+
- org.openrewrite.java.dependencies.ChangeDependency:
108+
oldGroupId: com.fasterxml.jackson.module
109+
oldArtifactId: jackson-module-jakarta-xmlbind-annotations
110+
newGroupId: tools.jackson.module
111+
newArtifactId: jackson-module-jakarta-xmlbind-annotations
112+
newVersion: 3.0.x
113+
- org.openrewrite.java.dependencies.ChangeDependency:
114+
oldGroupId: com.fasterxml.jackson.module
115+
oldArtifactId: jackson-module-mrbean
116+
newGroupId: tools.jackson.module
117+
newArtifactId: jackson-module-mrbean
118+
newVersion: 3.0.x
119+
- org.openrewrite.java.dependencies.ChangeDependency:
120+
oldGroupId: com.fasterxml.jackson.module
121+
oldArtifactId: jackson-module-jaxb-annotations
122+
newGroupId: tools.jackson.module
123+
newArtifactId: jackson-module-jaxb-annotations
124+
newVersion: 3.0.x
125+
- org.openrewrite.java.dependencies.ChangeDependency:
126+
oldGroupId: com.fasterxml.jackson.module
127+
oldArtifactId: jackson-module-afterburner
128+
newGroupId: tools.jackson.module
129+
newArtifactId: jackson-module-afterburner
130+
newVersion: 3.0.x
131+
- org.openrewrite.java.dependencies.ChangeDependency:
132+
oldGroupId: com.fasterxml.jackson.module
133+
oldArtifactId: jackson-module-guice7
134+
newGroupId: tools.jackson.module
135+
newArtifactId: jackson-module-guice7
136+
newVersion: 3.0.x
137+
- org.openrewrite.java.dependencies.ChangeDependency:
138+
oldGroupId: com.fasterxml.jackson.module
139+
oldArtifactId: jackson-modules-base
140+
newGroupId: tools.jackson.module
141+
newArtifactId: jackson-modules-base
142+
newVersion: 3.0.x
143+
- org.openrewrite.java.dependencies.ChangeDependency:
144+
oldGroupId: com.fasterxml.jackson.module
145+
oldArtifactId: jackson-module-osgi
146+
newGroupId: tools.jackson.module
147+
newArtifactId: jackson-module-osgi
148+
newVersion: 3.0.x
149+
- org.openrewrite.java.dependencies.ChangeDependency:
150+
oldGroupId: com.fasterxml.jackson.module
151+
oldArtifactId: jackson-module-guice
152+
newGroupId: tools.jackson.module
153+
newArtifactId: jackson-module-guice
154+
newVersion: 3.0.x
155+
- org.openrewrite.java.dependencies.ChangeDependency:
156+
oldGroupId: com.fasterxml.jackson.module
157+
oldArtifactId: jackson-module-android-record
158+
newGroupId: tools.jackson.module
159+
newArtifactId: jackson-module-android-record
160+
newVersion: 3.0.x
161+
- org.openrewrite.java.dependencies.ChangeDependency:
162+
oldGroupId: com.fasterxml.jackson.module
163+
oldArtifactId: jackson-module-blackbird
80164
newGroupId: tools.jackson.module
165+
newArtifactId: jackson-module-blackbird
81166
newVersion: 3.0.x
82167
- org.openrewrite.java.dependencies.ChangeDependency:
83168
oldGroupId: com.fasterxml.jackson.dataformat

src/test/java/org/openrewrite/java/jackson/Jackson3DependenciesTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -560,4 +560,30 @@ void jacksonDataformats(String format) {
560560
)
561561
);
562562
}
563+
564+
@Issue("https://github.com/openrewrite/rewrite-jackson/issues/49")
565+
@Test
566+
void jsonSchemaModuleIsNotMigrated() {
567+
rewriteRun(
568+
//language=xml
569+
pomXml(
570+
"""
571+
<project>
572+
<modelVersion>4.0.0</modelVersion>
573+
<groupId>org.example</groupId>
574+
<artifactId>example</artifactId>
575+
<version>1.0.0</version>
576+
<dependencies>
577+
<dependency>
578+
<groupId>com.fasterxml.jackson.module</groupId>
579+
<artifactId>jackson-module-jsonSchema</artifactId>
580+
<version>2.20.1</version>
581+
</dependency>
582+
</dependencies>
583+
</project>
584+
"""
585+
)
586+
);
587+
}
588+
563589
}

0 commit comments

Comments
 (0)